Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): mark the class/function in the new expression as used #5306

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

magic-akari
Copy link
Collaborator

@magic-akari magic-akari commented Aug 28, 2024

@github-actions github-actions bot added the A-linter Area - Linter label Aug 28, 2024
@camc314 camc314 requested a review from DonIsaac August 28, 2024 17:08
Copy link

graphite-app bot commented Aug 28, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

codspeed-hq bot commented Aug 28, 2024

CodSpeed Performance Report

Merging #5306 will not alter performance

Comparing fix/issue-5274 (b21c5a9) with main (08dc0ad)

Summary

✅ 29 untouched benchmarks

@DonIsaac
Copy link
Collaborator

Thanks @magic-akari!

@DonIsaac DonIsaac added C-bug Category - Bug P-high Priority - High blocker and removed P-high Priority - High labels Aug 28, 2024
@DonIsaac DonIsaac merged commit 318479e into main Aug 28, 2024
25 checks passed
@DonIsaac DonIsaac deleted the fix/issue-5274 branch August 28, 2024 17:38
Boshen added a commit that referenced this pull request Aug 29, 2024
## [0.9.1] - 2024-08-29

### Features

- 6633972 linter: Add fixer for `no-empty` (#5276) (camc314)
- a58e448 linter/eslint: Add fixer to `no-var` (#5144) (camc314)
- a6e9769 linter/jsx-a11y: Add `label-has-associated-control` (#5163)
(Billy Levin)
- c8e8532 linter/unicorn: Add fixer to `throw-new-error` (#5275)
(camc314)
- 7ccde4b linter/unicorn: Add fixer to `prefer-date-now` (#5147)
(camc314)

### Bug Fixes

- 76e86f8 linter: Eslint-plugin-unicorn prefer-spread wrong linter
suggestion on variables of type string (#5265) (Arian94)
- b39544e linter/jest: Fixer for `prefer-jest-mocked` creates invalid
LHS expressions (#5243) (camc314)
- 9953fa5 linter/no-null: Incorrect fixer for `NullLiteral` within
`ReturnStatement` (#5247) (Dunqing)
- 318479e linter/no-unused-vars: Mark the class/function in the new
expression as used (#5306) (magic-akari)

### Refactor

- fa1d460 linter: Clean up Fixer and Message (#5308) (DonIsaac)

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter blocker C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(linter) false positive in no-unused-vars
2 participants