Consider neutral as final state when reporting (#2357)

Consider neutral as final state when reporting These can be e.g.configuration errors and we should notify about those users. Fixes #2325 RELEASE NOTES BEGIN We have fixed the reporting of configuration errors in GitLab. RELEASE NOTES END Reviewed-by: Matej Focko
packit · Feb 28, 2024 · 1ed0574 · 1ed0574
2 parents d041308 + 8a4c6bb
commit 1ed0574
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/packit_service/worker/helpers/job_helper.py b/packit_service/worker/helpers/job_helper.py
@@ -199,14 +199,9 @@ def _report(
                 " For more details see our [guide](https://packit.dev/docs/guide#gitlab)."
             )
 
-            final_commit_states = (
-                BaseCommitStatus.success,
-                BaseCommitStatus.failure,
-                BaseCommitStatus.error,
-            )
             # We are only commenting final states to avoid multiple comments for a build
             # Ignoring all other states eg. pending, running
-            if state not in final_commit_states:
+            if not StatusReporter.is_final_state(state):
                 return
 
         self.status_reporter.report(

diff --git a/packit_service/worker/reporting/reporters/base.py b/packit_service/worker/reporting/reporters/base.py
@@ -160,6 +160,7 @@ def is_final_state(state: BaseCommitStatus) -> bool:
             BaseCommitStatus.success,
             BaseCommitStatus.error,
             BaseCommitStatus.failure,
+            BaseCommitStatus.neutral,
         }
 
     def _add_commit_comment_with_status(