Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reporting errors on GitLab #2325

Closed
2 tasks done
mfocko opened this issue Jan 31, 2024 · 0 comments · Fixed by #2357
Closed
2 tasks done

Reporting errors on GitLab #2325

mfocko opened this issue Jan 31, 2024 · 0 comments · Fixed by #2357
Assignees
@lbarcziova
Labels
area/gitlab Related to GitLab implementation. area/testing-farm Related to Testing Farm integration. complexity/single-task Regular task, should be done within days. gain/high This brings a lot of value to (not strictly a lot of) users. impact/low This issue impacts only a few users. kind/bug Something isn't working.

Comments

@mfocko
Copy link
Member

mfocko commented Jan 31, 2024

What happened? What is the problem?

Packit failed to notify user via comment about the failure on GitLab when there's no access to the repository to set the commit statuses.

What did you expect to happen?

Fallback to the comment notification.

Example URL(s)

MR: https://gitlab.com/efedin/compose-tests/-/merge_requests/1
Comment: https://gitlab.com/efedin/compose-tests/-/merge_requests/1#note_1750278441

Steps to reproduce

1. MR got triggered via the comment `/packit test`
2. Logic part on our side deduced there are no tests
3. Reports the error via commit (visible in the logs):
   https://github.com/packit/packit-service/blob/7337498d73eed935e6196696a518d3ea69ef4ad7/packit_service/worker/helpers/testing_farm.py#L935-L942
4. Since Packit is not present in the repo, it fails.

What is the impacted category (job)?

Testing Farm tests

Workaround

  • There is an existing workaround that can be used until this issue is fixed.

Participation

  • I am willing to submit a pull request for this issue. (Packit team is happy to help!)
@mfocko mfocko added kind/bug Something isn't working. area/gitlab Related to GitLab implementation. complexity/single-task Regular task, should be done within days. impact/low This issue impacts only a few users. gain/high This brings a lot of value to (not strictly a lot of) users. area/testing-farm Related to Testing Farm integration. labels Jan 31, 2024
@lbarcziova lbarcziova self-assigned this Feb 28, 2024
lbarcziova added a commit to lbarcziova/packit-service that referenced this issue Feb 28, 2024
@lbarcziova
Consider neutral as final state when reporting
8a4c6bb 
These can be e.g.configuration errors and we should notify about these
users.
Fixes packit#2325
@lbarcziova lbarcziova mentioned this issue Feb 28, 2024
Merged
softwarefactory-project-zuul bot added a commit that referenced this issue Feb 28, 2024
@softwarefactory-project-zuul
Consider neutral as final state when reporting (#2357)
1ed0574 
Consider neutral as final state when reporting

These can be e.g.configuration errors and we should notify about those users.
Fixes #2325
RELEASE NOTES BEGIN
We have fixed the reporting of configuration errors in GitLab.
RELEASE NOTES END

Reviewed-by: Matej Focko
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lbarcziova lbarcziova

Labels
area/gitlab Related to GitLab implementation. area/testing-farm Related to Testing Farm integration. complexity/single-task Regular task, should be done within days. gain/high This brings a lot of value to (not strictly a lot of) users. impact/low This issue impacts only a few users. kind/bug Something isn't working.
Projects
Packit Kanban Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Consider neutral as final state when reporting lbarcziova/packit-service
2 participants
@mfocko @lbarcziova