Skip to content

Commit

Permalink
Do not filter out branches to fast forward
Browse files Browse the repository at this point in the history
When retriggering propose-downstream for a branch
we want to fast forward the merge without filters.
  • Loading branch information
majamassarini committed Oct 4, 2024
1 parent 87daf58 commit ed9b781
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
3 changes: 1 addition & 2 deletions packit_service/worker/helpers/sync_release/sync_release.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,13 +82,12 @@ def get_fast_forward_merge_branches_for(self, source_branch: str) -> Set[str]:
source_branch: source branch
"""
branches = aliases.get_fast_forward_merge_branches_for(
return aliases.get_fast_forward_merge_branches_for(
self.job.dist_git_branches,
source_branch,
default=self.default_dg_branch,
default_dg_branch=self.default_dg_branch,
)
return self._filter_override_branches(branches)

@property
def job(self) -> Optional[JobConfig]:
Expand Down
5 changes: 2 additions & 3 deletions tests/unit/test_propose_downstream.py
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,6 @@
trigger=JobConfigTriggerType.release,
packages={
"package": CommonPackageConfig(
# no sense but possible!
dist_git_branches={
"f41": {"fast_forward_merge_into": ["f40", "f39"]},
"f38": {"fast_forward_merge_into": ["f37"]},
Expand All @@ -139,9 +138,9 @@
),
],
JobConfigTriggerType.release,
{"f41", "f40"},
{"f41"},
{"f41": {"f40"}},
{"f41"},
{"f41": {"f40", "f39"}},
),
],
)
Expand Down

0 comments on commit ed9b781

Please sign in to comment.