Skip to content
This repository has been archived by the owner on Dec 6, 2023. It is now read-only.

Fix build on circle CI #21

Merged
merged 10 commits into from
Jun 20, 2019
Merged

Fix build on circle CI #21

merged 10 commits into from
Jun 20, 2019

Conversation

Undermaken
Copy link
Contributor

This PR aims to fix isseus about circle CI build

@Undermaken
fix test
9e4cf9b 
fix minor bugs
@Undermaken Undermaken requested a review from cloudify June 17, 2019 13:56
@Undermaken
remove useless variable
177126b 
fix lint warnings
@cloudify cloudify changed the title Fix build on circe CI Fix build on circle CI Jun 17, 2019
@lgtm-com
Copy link

lgtm-com bot commented Jun 17, 2019

This pull request fixes 2 alerts when merging 177126b into 7343177 - view on LGTM.com

fixed alerts:

  • 2 for Unused variable, import, function or class

cloudify
cloudify suggested changes Jun 17, 2019
View reviewed changes
src/utils/azure.ts Outdated Show resolved Hide resolved
src/utils/azure.ts Show resolved Hide resolved
test/commands/users/list.test.ts Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 17, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@7343177). Click here to learn what that means.
The diff coverage is 63.63%.

@@            Coverage Diff            @@
##             master      #21   +/-   ##
=========================================
  Coverage          ?   37.36%           
=========================================
  Files             ?        7           
  Lines             ?      182           
  Branches          ?        9           
=========================================
  Hits              ?       68           
  Misses            ?      113           
  Partials          ?        1

@lgtm-com
Copy link

lgtm-com bot commented Jun 17, 2019

This pull request fixes 14 alerts when merging 4dd57d3 into 7343177 - view on LGTM.com

fixed alerts:

  • 14 for Unused variable, import, function or class

@Undermaken Undermaken marked this pull request as ready for review June 17, 2019 15:59
@Undermaken Undermaken requested a review from cloudify June 17, 2019 15:59
@lgtm-com
Copy link

lgtm-com bot commented Jun 17, 2019

This pull request fixes 14 alerts when merging a1cb99b into 7343177 - view on LGTM.com

fixed alerts:

  • 14 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Jun 18, 2019

This pull request fixes 14 alerts when merging 2f168e8 into 7343177 - view on LGTM.com

fixed alerts:

  • 14 for Unused variable, import, function or class

cloudify
cloudify suggested changes Jun 19, 2019
View reviewed changes
src/utils/azure.ts
primaryReadonlyMasterKey.exitCodeName === successExitCode
);
} catch (e) {
return false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it could be useful to log the exception to the console, at least it gives you a hint on why the command failed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used cli.log instead of cli.error because this one causes the test failure

@Undermaken Undermaken requested a review from cloudify June 20, 2019 15:22
@lgtm-com
Copy link

lgtm-com bot commented Jun 20, 2019

This pull request fixes 14 alerts when merging 5ce36b5 into 7343177 - view on LGTM.com

fixed alerts:

  • 14 for Unused variable, import, function or class

@cloudify cloudify merged commit c81d960 into master Jun 20, 2019
@cloudify cloudify deleted the fix-cci-build branch June 20, 2019 16:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cloudify cloudify cloudify approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Undermaken @cloudify