Fix build on circle CI

src/commands/messages/attributes.ts

@@ -3,13 +3,11 @@ import { Command, flags } from "@oclif/command";
 import cli from "cli-ux";
 import * as parse from "csv-parse";
 import * as fs from "fs";
-import * as t from "io-ts";
 import * as transform from "stream-transform";
 
 import {
   config,
   getCosmosEndpoint,
-  getCosmosReadonlyKey,
   getCosmosWriteKey
 } from "../../utils/azure";
 import { parseMessagePath } from "../../utils/parser";
@@ -42,6 +40,7 @@ export default class MessagesAttributes extends Command {
       this.exit();
     }
 
+    // tslint:disable-next-line: no-inferred-empty-object-type
     const messageDelta = [
       {
         key: "isPending",
@@ -95,7 +94,7 @@ export default class MessagesAttributes extends Command {
       cli.action.stop();
 
       const client = new cosmos.CosmosClient({ endpoint, auth: { key } });
-      const database = await client.database(config.cosmosDatabaseName);
+      const database = client.database(config.cosmosDatabaseName);
       const container = database.container(config.cosmosMessagesContainer);
 
       const updateMessage = async (fiscalCode: string, messageId: string) => {
@@ -133,7 +132,7 @@ export default class MessagesAttributes extends Command {
         .pipe(transformer)
         .pipe(process.stdout);
 
-      await new Promise((res, rej) => parser.on("end", res));
+      await new Promise((res, _) => parser.on("end", res));
     } catch (e) {
       this.error(e);
     }

src/commands/profiles/list.ts

@@ -24,9 +24,9 @@ export default class ProfilesList extends Command {
 
       cli.action.start("Querying profiles...");
       const client = new cosmos.CosmosClient({ endpoint, auth: { key } });
-      const database = await client.database("agid-documentdb-test");
+      const database = client.database("agid-documentdb-test");
       const container = database.container("profiles");
-      const response = await container.items.query(
+      const response = container.items.query(
         "SELECT c.fiscalCode, c._ts FROM c WHERE c.version = 0",
         {
           enableCrossPartitionQuery: true

src/utils/azure.ts

@@ -42,3 +42,21 @@ export const getStorageConnection = async (name: string) =>
   (await execa(
     `az storage account show-connection-string --name ${name} --output tsv`
   )).stdout;
+
+/**
+ * hasCosmosConnection checks if the host has az cli installed and resouceGroup and name
+ * are valid inputs for cosmosdb
+ */
+export const hasCosmosConnection = (resourceGroup: string, name: string) => {
+  try {
+    execa.sync(
+      `az cosmosdb show -g ${resourceGroup} -n ${name} --query documentEndpoint -o tsv`
+    );
+    execa.sync(
+      `az cosmosdb list-keys -g ${resourceGroup} -n ${name} --query primaryReadonlyMasterKey -o tsv`
+    );
+    return true;
+  } catch (e) {
+    return false;
+  }
+};

test/commands/hello.test.ts

@@ -1,17 +1,17 @@
-import {expect, test} from '@oclif/test'
+import { expect, test } from "@oclif/test";
 
-describe('hello', () => {
+describe("hello", () => {
   test
     .stdout()
-    .command(['hello'])
-    .it('runs hello', ctx => {
-      expect(ctx.stdout).to.contain('hello world')
-    })
+    .command(["hello"])
+    .it("runs hello world", ctx => {
+      expect(ctx.stdout).to.contain("hello world");
+    });
 
   test
     .stdout()
-    .command(['hello', '--name', 'jeff'])
-    .it('runs hello --name jeff', ctx => {
-      expect(ctx.stdout).to.contain('hello jeff')
-    })
-})
+    .command(["hello", "--name", "jeff"])
+    .it("runs hello --name jeff", ctx => {
+      expect(ctx.stdout).to.contain("hello jeff");
+    });
+});

test/commands/users/list.test.ts

@@ -1,17 +1,29 @@
-import {expect, test} from '@oclif/test'
+import { expect, test } from "@oclif/test";
+import { hasCosmosConnection } from "../../../src/utils/azure";
 
-describe('users:list', () => {
-  test
-    .stdout()
-    .command(['users:list'])
-    .it('runs hello', ctx => {
-      expect(ctx.stdout).to.contain('hello world')
-    })
-
-  test
-    .stdout()
-    .command(['users:list', '--name', 'jeff'])
-    .it('runs hello --name jeff', ctx => {
-      expect(ctx.stdout).to.contain('hello jeff')
-    })
-})
+describe("list all profiles", () => {
+  const isCosmosConnectionAvailable = hasCosmosConnection(
+    "agid-rg-test",
+    "agid-cosmosdb-test"
+  );
+  /**
+   * if host has the az client installed and valid cosmos credentials we test command first output line matches
+   * the header row (fiscalCode column name). Otherwise the test expects for an error with 2 as exit status
+   */
+  if (isCosmosConnectionAvailable) {
+    test
+      .stdout()
+      .command(["profiles:list"])
+      .it("runs profiles command to list all users", ctx => {
+        expect(ctx.stdout).match(/^fiscalCode/);
+      });
+  } else {
+    test
+      .stdout()
+      .command(["profiles:list"])
+      .exit(2)
+      .it(
+        "check the command goes in error (no cosmos credential available or az client not installed)"
+      );
+  }
+});

test/mocha.opts

@@ -2,4 +2,4 @@
 --watch-extensions ts
 --recursive
 --reporter spec
---timeout 5000
+--timeout 15000