Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pants fails to run under python 3.7 #6363

Closed
jsirois opened this issue Aug 17, 2018 · 2 comments · Fixed by #6594
Closed

Pants fails to run under python 3.7 #6363

jsirois opened this issue Aug 17, 2018 · 2 comments · Fixed by #6594
Assignees
@jsirois
Labels
bug

Comments

@jsirois
Copy link
Contributor

jsirois commented Aug 17, 2018 •
edited
Loading

We hit the issue fixed here https://setuptools.readthedocs.io/en/latest/history.html#v38-4-1 for the cryptography distribution. Pants/pex should be upgraded to this version or newer of setuptools.
@jsirois jsirois self-assigned this Aug 17, 2018
@jsirois jsirois mentioned this issue Aug 17, 2018
Closed
@jsirois
Copy link
Contributor Author

jsirois commented Aug 17, 2018

Fixing this will likely be part of finishing #6062

jsirois added a commit to jsirois/pants that referenced this issue Aug 17, 2018
@jsirois
Pin interpreter <3.7 in ci.
f951d8e 
Pants does not currently work in 3.7 and this helps repro issues in CI
on a developer workstation that has 3.7 and 3.lower.

Part of work on pantsbuild#6363.
jsirois added a commit to jsirois/pants that referenced this issue Aug 17, 2018
@jsirois
Pin interpreter <3.7 in ci.
a98412e 
Pants does not currently work in 3.7 and this helps repro issues in CI
on a developer workstation that has 3.7 and 3.lower.

Part of work on pantsbuild#6363.
@jsirois jsirois mentioned this issue Aug 17, 2018
Merged
jsirois added a commit to jsirois/pants that referenced this issue Aug 18, 2018
@jsirois
Pin interpreter <3.7 in ci.
f6d4067 
Pants does not currently work in 3.7 and this helps repro issues in CI
on a developer workstation that has 3.7 and 3.lower.

Part of work on pantsbuild#6363.
@jsirois jsirois mentioned this issue Aug 18, 2018
Merged
jsirois added a commit to jsirois/pants that referenced this issue Aug 20, 2018
@jsirois
Pin interpreter <3.7 in ci.
bd6cfd6 
Pants does not currently work in 3.7 and this helps repro issues in CI
on a developer workstation that has 3.7 and 3.lower.

Part of work on pantsbuild#6363.
jsirois added a commit that referenced this issue Aug 21, 2018
@jsirois
Pin interpreter <3.7 in ci. (#6364)
c82379f 
Pants does not currently work in 3.7 and this helps repro issues in CI
on a developer workstation that has 3.7 and 3.lower.

Part of work on #6363.
@jsirois
Copy link
Contributor Author

jsirois commented Aug 24, 2018

With the release of pex 1.4.6 this issue can be resolved with a Pants upgarde of its pex requirement.

@jsirois jsirois mentioned this issue Oct 4, 2018
Closed
jsirois added a commit to jsirois/pants that referenced this issue Oct 4, 2018
@jsirois
Upgrade to pex 1.4.8 and eliminate workarounds.
bd154f2 
Pex now allows us to float setuptools high and run on python 3.7 and
it supports sane platform expansion as well as graceful handling of
non-standard `setuptools` platform reporting for Apple system
interpreters allowing us to eliminate several workarounds.

We also pickup a fix for concurrent pex extraction which is particularly
useful when running pants from a pex using `PEX_FORCE_LOCAL`.

Fixes pantsbuild#5922
Fixes pantsbuild#6363
@jsirois jsirois mentioned this issue Oct 4, 2018
Merged
jsirois added a commit to jsirois/pants that referenced this issue Oct 5, 2018
@jsirois
Upgrade to pex 1.4.8 and eliminate workarounds.
e0ef9cd 
Pex now allows us to float setuptools high and run on python 3.7 and
it supports sane platform expansion as well as graceful handling of
non-standard `setuptools` platform reporting for Apple system
interpreters allowing us to eliminate several workarounds.

We also pickup a fix for concurrent pex extraction which is particularly
useful when running pants from a pex using `PEX_FORCE_LOCAL`.

Fixes pantsbuild#5922
Fixes pantsbuild#6363
jsirois added a commit to jsirois/pants that referenced this issue Oct 7, 2018
@jsirois
Upgrade to pex 1.4.8 and eliminate workarounds.
bfb214e 
Pex now allows us to float setuptools high and run on python 3.7 and
it supports sane platform expansion as well as graceful handling of
non-standard `setuptools` platform reporting for Apple system
interpreters allowing us to eliminate several workarounds.

We also pickup a fix for concurrent pex extraction which is particularly
useful when running pants from a pex using `PEX_FORCE_LOCAL`.

Fixes pantsbuild#5922
Fixes pantsbuild#6363
jsirois added a commit that referenced this issue Oct 8, 2018
@jsirois
Upgrade to pex 1.4.8 and eliminate workarounds. (#6594)
38ccf42 
Pex now allows us to float setuptools high and run on python 3.7 and
it supports sane platform expansion as well as graceful handling of
non-standard `setuptools` platform reporting for Apple system
interpreters allowing us to eliminate several workarounds.

We also pickup a fix for concurrent pex extraction which is particularly
useful when running pants from a pex using `PEX_FORCE_LOCAL`.

Fixes #5922
Fixes #6363
Eric-Arellano added a commit to Eric-Arellano/pants that referenced this issue Dec 15, 2018
@Eric-Arellano
Python 3.7 now works (pantsbuild#6363)
8faf476
Eric-Arellano added a commit that referenced this issue Dec 15, 2018
@Eric-Arellano
Fix Travis environment variable overriding interpreter_selection test…
62995e3 
…'s config (#6939)

### Problem
In `test_conflict_via_config()`, we try to constraint Python to `< 2.7`. However, this fails to do anything when running on Python 3, because it's overriden by `ci.sh`'s environment variable `export PANTS_PYTHON_SETUP_INTERPRETER_CONSTRAINTS='["CPython>=3.5,<4"]'`.

This is expected behavior, that the environment variable overrides the command line argument. So, the issue is not with the source code, but this test should also not be failing.

### Solution
Set the integration test to be hermetic.

### Other related interpreter selection changes
* Allow Python 3.7 now that it's been fixed with #6363 
* In CI, require for Python 3 mode Python 3.5+, now that we use xenial (#6885)
@Eric-Arellano Eric-Arellano mentioned this issue Jan 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsirois jsirois

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade to pex 1.4.8 and eliminate workarounds. jsirois/pants
1 participant
@jsirois