Fix Travis environment variable overriding interpreter_selection test's config #6939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsirois
approved these changes
Dec 15, 2018
Eric-Arellano
commented
Dec 15, 2018
| # TODO(John Sirois): Allow `<4` when the issues with `3.7` are fixed. See: | ||
| # https://github.com/pantsbuild/pants/issues/6363 | ||
| compatibility = ['CPython>=2.7,<3.7'] | ||
| compatibility = ['CPython>=2.7,<4'] |
There was a problem hiding this comment.
I noticed while debugging this that this line seems out of date now. But fixing it might be scope creep? Lmk if better to remove this from PR.
Eric-Arellano
commented
Dec 15, 2018
| banner "Setting interpreter constraints for 3!" | ||
| export PANTS_PYTHON_SETUP_INTERPRETER_CONSTRAINTS='["CPython>=3.4,<4"]' | ||
| export PANTS_PYTHON_SETUP_INTERPRETER_CONSTRAINTS='["CPython>=3.5,<4"]' |
There was a problem hiding this comment.
This was fixed by 7da3ab5, but we didn't notice then.
I think this might be fine for scope creep, because it directly ties to the failing test, but let me know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In
test_conflict_via_config(), we try to constraint Python to< 2.7. However, this fails to do anything when running on Python 3, because it's overriden byci.sh's environment variableexport PANTS_PYTHON_SETUP_INTERPRETER_CONSTRAINTS='["CPython>=3.5,<4"]'.This is expected behavior, that the environment variable overrides the command line argument. So, the issue is not with the source code, but this test should also not be failing.
Solution
Set the integration test to be hermetic.