Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy for holding locks between multiple awaits #548

Merged
merged 1 commit into from
May 25, 2022
Merged

Conversation

lexnv
Copy link
Collaborator

@lexnv lexnv commented May 24, 2022

The issue was related to holding the internal subxt's client metadata
RwLock between multiple await points.

This PR ensures the metadata is cloned and the lock guard dropped
immediately.

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv lexnv merged commit 962ca61 into master May 25, 2022
@lexnv lexnv deleted the fix_clippy branch May 25, 2022 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants