Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clippy for holding locks between multiple awaits #548

Merged
merged 1 commit into from
May 25, 2022
Merged

Fix clippy for holding locks between multiple awaits #548

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions integration-tests/src/metadata/validation.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,11 @@ async fn full_metadata_check() {
assert!(api.validate_metadata().is_ok());

// Modify the metadata.
let locked_client_metadata = api.client.metadata();
let client_metadata = locked_client_metadata.read();
let mut metadata: RuntimeMetadataV14 = client_metadata.runtime_metadata().clone();
let mut metadata: RuntimeMetadataV14 = {
let locked_client_metadata = api.client.metadata();
let client_metadata = locked_client_metadata.read();
client_metadata.runtime_metadata().clone()
};
metadata.pallets[0].name = "NewPallet".to_string();

let new_api = metadata_to_api(metadata, &cxt).await;
Expand All @@ -100,9 +102,11 @@ async fn constants_check() {
assert!(cxt.api.constants().balances().existential_deposit().is_ok());

// Modify the metadata.
let locked_client_metadata = api.client.metadata();
let client_metadata = locked_client_metadata.read();
let mut metadata: RuntimeMetadataV14 = client_metadata.runtime_metadata().clone();
let mut metadata: RuntimeMetadataV14 = {
let locked_client_metadata = api.client.metadata();
let client_metadata = locked_client_metadata.read();
client_metadata.runtime_metadata().clone()
};

let mut existential = metadata
.pallets
Expand Down