Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plumb --pip-version to Platform tag calculation. #1894

Closed
jsirois opened this issue Aug 26, 2022 · 0 comments · Fixed by #2538
Closed

Plumb --pip-version to Platform tag calculation. #1894

jsirois opened this issue Aug 26, 2022 · 0 comments · Fixed by #2538
Assignees
@jsirois
Labels
enhancement resolver tech-debt Issue that addresses technical debt.

Comments

@jsirois
Copy link
Member

jsirois commented Aug 26, 2022

This is the last un-parametrized production use of get_pip():
https://github.com/pantsbuild/pex/blob/63592214c569c03b60c59766f96fdd2832e698b6/pex/platforms.py#L209-L239
@jsirois jsirois mentioned this issue Sep 20, 2022
Closed
1 task
This was referenced Sep 29, 2022
Closed
Closed
Closed
Closed
@jsirois jsirois mentioned this issue Oct 9, 2022
Closed
2 tasks
This was referenced Oct 18, 2022
Closed
Closed
@jsirois jsirois mentioned this issue Nov 3, 2022
Closed
2 tasks
This was referenced Nov 21, 2022
Closed
Closed
Closed
@jsirois jsirois mentioned this issue Nov 28, 2022
Closed
2 tasks
This was referenced Dec 8, 2022
Closed
Closed
@jsirois jsirois mentioned this issue Jan 9, 2023
Closed
2 tasks
@jsirois jsirois mentioned this issue Jan 18, 2023
Closed
3 tasks
This was referenced Feb 12, 2023
Closed
Closed
This was referenced Feb 25, 2023
Closed
Closed
Closed
This was referenced Mar 7, 2023
Closed
Closed
Closed
@jsirois jsirois mentioned this issue Mar 23, 2023
Closed
2 tasks
@jsirois jsirois mentioned this issue Mar 30, 2023
Closed
2 tasks
@jsirois jsirois mentioned this issue Apr 21, 2023
Closed
4 tasks
This was referenced May 1, 2023
Closed
Closed
@jsirois jsirois mentioned this issue May 13, 2023
Closed
2 tasks
@jsirois jsirois mentioned this issue Jul 1, 2023
Closed
3 tasks
@jsirois jsirois self-assigned this Jul 5, 2023
This was referenced Jul 21, 2023
Closed
Closed
Closed
This was referenced Aug 3, 2023
Closed
Closed
@jsirois jsirois mentioned this issue Aug 12, 2023
Closed
1 task
This was referenced Aug 22, 2023
Closed
Closed
@jsirois jsirois mentioned this issue Sep 18, 2023
Closed
1 task
@jsirois jsirois mentioned this issue Sep 30, 2023
Closed
1 task
This was referenced Nov 2, 2023
Closed
Closed
Closed
jsirois added a commit to jsirois/pex that referenced this issue Sep 18, 2024
@jsirois
Plumb --pip-version to Platform tag calculation.
f3d44da 
Fixes pex-tool#1894
jsirois added a commit to jsirois/pex that referenced this issue Sep 18, 2024
@jsirois
Plumb --pip-version to Platform tag calculation.
bbfbf9c 
This fixes a long-standing discrepency between the selected
`--pip-version` and the Pip actually used to determine abbreviated
`--platform` compatibility tags. With the `--pip-log` enhancement
from pex-tool#2536 the calculated abbreviated platform tags are now always
logged to the Pip log, which is very useful for debugging failed
resolves using abbreviated platforms.

Fixes pex-tool#1894
@jsirois jsirois mentioned this issue Sep 18, 2024
Merged
@jsirois jsirois added the tech-debt Issue that addresses technical debt. label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsirois jsirois

Labels
enhancement resolver tech-debt Issue that addresses technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Plumb --pip-version to Platform tag calculation. jsirois/pex
1 participant
@jsirois