Add the ability to specify the --pip-log path.
#2536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although `--pip-log` is just an alias for the pre-existing `--preserve-pip-download-log` option, the option gains the ability to accept an optional log path value. In addition to this pro-active means of starting a debuggable Pex session with Pip, the log is also made more useful in the face of a multi-target resolve by serializing the log on targets and prefixing log lines per target.
jsirois
added a commit
to jsirois/pex
that referenced
this pull request
Sep 18, 2024
This fixes a long-standing discrepency between the selected `--pip-version` and the Pip actually used to determine abbreviated `--platform` compatibility tags. With the `--pip-log` enhancement from pex-tool#2536 the calculated abbreviated platform tags are now always logged to the Pip log, which is very useful for debugging failed resolves using abbreviated platforms. Fixes pex-tool#1894
jsirois
added a commit
that referenced
this pull request
Sep 18, 2024
This fixes a long-standing discrepency between the selected `--pip-version` and the Pip actually used to determine abbreviated `--platform` compatibility tags. With the `--pip-log` enhancement from #2536 the calculated abbreviated platform tags are now always logged to the Pip log, which is very useful for debugging failed resolves using abbreviated platforms. Fixes #1894
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although
--pip-logis just an alias for the pre-existing--preserve-pip-download-logoption, the option gains the ability toaccept an optional log path value. In addition to this pro-active means
of starting a debuggable Pex session with Pip, the log is also made more
useful in the face of a multi-target resolve by serializing the log on
targets and prefixing log lines per target. The log now also includes
the compatibility tags calculated via
pip -v debug ...for anyabbreviated
--platforms used in the resolve.