Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

*: update tidb #1079

Closed
wants to merge 1 commit into from
Closed

*: update tidb #1079

wants to merge 1 commit into from

Conversation

sticnarf
Copy link
Contributor

@sticnarf sticnarf commented Apr 30, 2021

What problem does this PR solve?

Lock resolving in TiDB has a bug: pingcap/tidb#24384.

What is changed and how it works?

Update TiDB to the latest version with the bug fixed.

Check List

Tests

  • No code

Related changes

  • Need to cherry-pick to the release branch

Release Note

  • No release note

@kennytm
Copy link
Collaborator

kennytm commented May 5, 2021

Please update the (*mockChecksumKVClient) Send function in pkg/lightning/restore/checksum_test.go.

[2021-04-30T09:15:40.673Z] pkg/lightning/restore/checksum_test.go:178:76: cannot use kvClient (type *mockChecksumKVClient) as type "github.com/pingcap/tidb/kv".Client in field value:

[2021-04-30T09:15:40.673Z] 	*mockChecksumKVClient does not implement "github.com/pingcap/tidb/kv".Client (wrong type for Send method)

[2021-04-30T09:15:40.673Z] 		have Send(context.Context, *"github.com/pingcap/tidb/kv".Request, *"github.com/pingcap/tidb/store/tikv/kv".Variables, *memory.Tracker, bool) "github.com/pingcap/tidb/kv".Response

[2021-04-30T09:15:40.673Z] 		want Send(context.Context, *"github.com/pingcap/tidb/kv".Request, interface {}, *memory.Tracker, bool) "github.com/pingcap/tidb/kv".Response

@sticnarf
Copy link
Contributor Author

sticnarf commented May 7, 2021

/run-integration-tests

@sticnarf
Copy link
Contributor Author

sticnarf commented May 9, 2021

/run-all-tests

Signed-off-by: Yilin Chen <sticnarf@gmail.com>
@sticnarf
Copy link
Contributor Author

@kennytm @overvenus PTAL, thanks!

@kennytm
Copy link
Collaborator

kennytm commented May 10, 2021

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • kennytm

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 LGTM1 label May 10, 2021
@ti-chi-bot
Copy link
Member

@sticnarf: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sticnarf
Copy link
Contributor Author

Superseded by #1103

@sticnarf sticnarf closed this May 16, 2021
@sticnarf sticnarf deleted the update-tidb branch May 17, 2021 03:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants