Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

*: update tidb #1103

Merged
merged 1 commit into from
May 14, 2021
Merged

*: update tidb #1103

merged 1 commit into from
May 14, 2021

Conversation

disksing
Copy link
Contributor

@disksing disksing commented May 13, 2021

Signed-off-by: disksing i@disksing.com

What problem does this PR solve?

update tidb dependency

What is changed and how it works?

  • go get -u tidb
  • update mockChecksumKVClient to meet new interface
  • use kv.PriorityLow instead of tikvstore.PriorityLow

Check List

Tests

  • Unit test

Release note

  • No release note

Signed-off-by: disksing <i@disksing.com>
@sre-bot
Copy link
Contributor

sre-bot commented May 13, 2021

@disksing
Copy link
Contributor Author

/run-check_release_note

@kennytm
Copy link
Collaborator

kennytm commented May 13, 2021

/run-check-release-note

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 LGTM1 label May 13, 2021
@tisonkun
Copy link

@disksing iiuc Release Note should be Release note because it checks exactly matched.

@disksing
Copy link
Contributor Author

disksing commented May 14, 2021

@disksing iiuc Release Note should be Release note because it checks exactly matched.

Interesting. Release Note is from the PR template.

@disksing
Copy link
Contributor Author

/run-check-release-note

@overvenus
Copy link
Member

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • kennytm
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels May 14, 2021
@overvenus
Copy link
Member

/lgtm

@kennytm
Copy link
Collaborator

kennytm commented May 14, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f848716

@ti-chi-bot ti-chi-bot merged commit 7ce705d into pingcap:master May 14, 2021
@disksing disksing deleted the update branch May 15, 2021 03:59
@sticnarf sticnarf mentioned this pull request May 16, 2021
3pointer pushed a commit to 3pointer/br that referenced this pull request Jun 4, 2021
3pointer pushed a commit to 3pointer/br that referenced this pull request Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants