Skip to content
This repository has been archived by the owner on Aug 21, 2023. It is now read-only.

*: replace storage.Create by storage.New, upgrade dumpling CI to go 1.16 #286

Merged
merged 5 commits into from
Jun 2, 2021

Conversation

lichunzhu
Copy link
Contributor

@lichunzhu lichunzhu commented May 27, 2021

What problem does this PR solve?

https://github.com/pingcap/br/issues/898

  1. storage.Create has been deprecated... so let's replace the remaining two calls from Dumpling.
  2. Dumpling originally used storage.Create(sendCreds=true), but
    the entire cloud access happens within Lightning, so we don't need to send credentials to anyone
    this introduced skipCheckPath=false.

What is changed and how it works?

  1. Changed storage.Create to storage.New with sendCreds=false and skipCheckPath=true.
  2. Upgrade dumpling go version to 1.16.

Check List

Tests

  • Unit test
  • Integration test

Side effects

Related changes

Release note

  • When using Dumpling to export to S3, we no longer require s3:ListBucket permission on the entire bucket, only the data source prefix itself.

@glorv
Copy link
Collaborator

glorv commented May 27, 2021

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • glorv

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 One reviewer approved (LGTM1) label May 27, 2021
@lichunzhu
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7165478

@lichunzhu
Copy link
Contributor Author

/hold

@lichunzhu
Copy link
Contributor Author

/unhold

@lichunzhu lichunzhu changed the title external-storage: replace storage.Create by storage.New *: replace storage.Create by storage.New, upgrade dumpling CI to go 1.16 Jun 2, 2021
@lichunzhu
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b5c6bc4

@ti-chi-bot ti-chi-bot merged commit 292cbe6 into pingcap:master Jun 2, 2021
ti-chi-bot pushed a commit to ti-chi-bot/dumpling that referenced this pull request Jun 2, 2021
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #287.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #288.

@lichunzhu lichunzhu deleted the fixCheckPath branch June 2, 2021 04:25
tisonkun pushed a commit to tisonkun/dumpling that referenced this pull request Oct 20, 2021
tisonkun pushed a commit to tisonkun/dumpling that referenced this pull request Oct 20, 2021
tisonkun pushed a commit to tisonkun/dumpling that referenced this pull request Oct 20, 2021
tisonkun pushed a commit to tisonkun/dumpling that referenced this pull request Oct 20, 2021
tisonkun pushed a commit to tisonkun/tidb that referenced this pull request Oct 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants