Skip to content
This repository has been archived by the owner on Aug 21, 2023. It is now read-only.

*: replace storage.Create by storage.New, update BR dependencies (#286) #287

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #286

What problem does this PR solve?

https://github.com/pingcap/br/issues/898

  1. storage.Create has been deprecated... so let's replace the remaining two calls from Dumpling.
  2. Dumpling originally used storage.Create(sendCreds=true), but
    the entire cloud access happens within Lightning, so we don't need to send credentials to anyone
    this introduced skipCheckPath=false.

What is changed and how it works?

  1. Changed storage.Create to storage.New with sendCreds=false and skipCheckPath=true.
  2. Upgrade dumpling go version to 1.16.

Check List

Tests

  • Unit test
  • Integration test

Side effects

Related changes

Release note

  • When using Dumpling to export to S3, we no longer require s3:ListBucket permission on the entire bucket, only the data source prefix itself.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
go.mod Outdated Show resolved Hide resolved
tools/go.mod Outdated
@@ -1,6 +1,6 @@
module github.com/pingcap/dumpling/_tools

go 1.13
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we keep this 1.13

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • kennytm

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 One reviewer approved (LGTM1) label Jul 13, 2021
@lichunzhu
Copy link
Contributor

/hold

@lichunzhu lichunzhu changed the title *: replace storage.Create by storage.New, upgrade dumpling CI to go 1.16 (#286) *: replace storage.Create by storage.New, update BR dependencies (#286) Jul 14, 2021
@lichunzhu lichunzhu added this to the v4.0.14 milestone Jul 15, 2021
@lichunzhu
Copy link
Contributor

/unhold

@lichunzhu
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 9a9a2a5

@ti-chi-bot ti-chi-bot merged commit 4ad1c86 into pingcap:release-4.0 Jul 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants