-
Notifications
You must be signed in to change notification settings - Fork 85
*: replace storage.Create by storage.New, update BR dependencies (#286) #287
*: replace storage.Create by storage.New, update BR dependencies (#286) #287
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
tools/go.mod
Outdated
@@ -1,6 +1,6 @@ | |||
module github.com/pingcap/dumpling/_tools | |||
|
|||
go 1.13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we keep this 1.13
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/hold |
/unhold |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 9a9a2a5
|
This is an automated cherry-pick of #286
What problem does this PR solve?
https://github.com/pingcap/br/issues/898
storage.Create
has been deprecated... so let's replace the remaining two calls from Dumpling.the entire cloud access happens within Lightning, so we don't need to send credentials to anyone
this introduced skipCheckPath=false.
What is changed and how it works?
storage.Create
tostorage.New
with sendCreds=false and skipCheckPath=true.Check List
Tests
Side effects
Related changes
Release note