*: fix upper-cased charset and collation name #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lonng
reviewed
Apr 28, 2019
bb7133
force-pushed
the
bb7133/fix_charset_case
branch
from
a5f2f21
to
88dcc69
Compare
|
addressed, PTAL @lonng @crazycs520 |
crazycs520
reviewed
Apr 28, 2019
| // TiDB always suppose all charsets / collations as lower-cased and try to convert them if they're not. | ||
| // However, the convert is missed in some scenarios before v2.1.9, so for all those tables prior to TableInfoVersion3, their | ||
| // charsets / collations will be converted to lower-case while loading from the storage. | ||
| TableInfoVersion3 = uint16(3) |
There was a problem hiding this comment.
Should we update column version too?
There was a problem hiding this comment.
IMHO it's not necessary, after all string case convert is not a heavy opeartion, using only TableInfoVersion makes the codes simple and clear.
crazycs520
reviewed
Apr 28, 2019
charset/charset_test.go
Outdated
| @@ -165,4 +178,5 @@ func BenchmarkGetCharsetDesc(b *testing.B) { | |||
| for i := 0; i < b.N; i++ { | |||
| GetCharsetDesc(cs) | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
remove this blank line.
bb7133
force-pushed
the
bb7133/fix_charset_case
branch
from
88dcc69
to
1a62285
Compare
|
hi @crazycs520 , please check my replys for your comments, thanks! |
bb7133
added a commit
to bb7133/parser
that referenced
this pull request
May 5, 2019
winkyao
pushed a commit
that referenced
this pull request
May 5, 2019
tiancaiamao
pushed a commit
to tiancaiamao/parser
that referenced
this pull request
Apr 27, 2021
lyonzhi
pushed a commit
to lyonzhi/parser
that referenced
this pull request
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This PR aims to fix the following 3 potential issues:
Validate collate name in parser and convert the name to lower case, as how charset is handled:
parser/parser.y
Line 5887 in e2cdb85
Added a new
TableInfoVersion3Added
utf8mb4_0900_ai_ciinmysqlpackage, as a tiny fix for suspend unknown collation id 255 error #294What is changed and how it works?
As stated above
Check List
Tests
Code changes
Side effects