Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: fix upper-cased charset and collation name (#301) #314

Merged
merged 1 commit into from
May 5, 2019
Merged

*: fix upper-cased charset and collation name (#301) #314

merged 1 commit into from
May 5, 2019

Conversation

bb7133
Copy link
Member

@bb7133 bb7133 commented May 5, 2019

Cherry-pick #301

@bb7133 bb7133 requested a review from crazycs520 May 5, 2019 07:39
@bb7133
Copy link
Member Author

bb7133 commented May 5, 2019

PTAL @crazycs520 @winkyao

crazycs520
crazycs520 reviewed May 5, 2019
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

winkyao
winkyao approved these changes May 5, 2019
View reviewed changes
Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winkyao winkyao merged commit b2f7fc7 into pingcap:release-2.1 May 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazycs520 crazycs520 crazycs520 left review comments

@winkyao winkyao winkyao approved these changes

Assignees
No one assigned
Labels
type/cherry-pick-for-release-2.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bb7133 @winkyao @crazycs520