refine export cleaner #2916
Merged
refine export cleaner #2916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cofyc
reviewed
Jul 13, 2020
| @@ -67,7 +68,7 @@ func (bo *Options) cleanRemoteBackupData(bucket string, opts []string) error { | |||
| destBucket := util.NormalizeBucketURI(bucket) | |||
| args := util.ConstructArgs(constants.RcloneConfigArg, opts, "deletefile", destBucket, "") | |||
| output, err := exec.Command("rclone", args...).CombinedOutput() | |||
| if err != nil { | |||
| if err != nil && !strings.Contains(err.Error(), "doesn't exist") { | |||
There was a problem hiding this comment.
does rclone document its exit codes?
There was a problem hiding this comment.
checking the error string is fragile, can we use the exit codes documented here?
There was a problem hiding this comment.
checking the error string is fragile, can we use the exit codes documented here?
nice advise! I will take a try
cofyc
approved these changes
Jul 14, 2020
|
/test pull-e2e-kind-serial |
|
/test pull-e2e-kind-serial |
ti-srebot
approved these changes
Jul 14, 2020
|
/test pull-e2e-kind-serial |
ti-srebot
pushed a commit
to ti-srebot/tidb-operator
that referenced
this pull request
Jul 14, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-1.1 in PR #2924 |
ti-srebot
added a commit
that referenced
this pull request
Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix #2914
What is changed and how does it work?
when rclone meet
doesn't existerror, make cleaner just ignore it.Check List
Tests
test delete BR and dumpling's backup file and then delete backup CR.
Related changes
Does this PR introduce a user-facing change?: