Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refine export cleaner (#2916) #2924

Merged
merged 1 commit into from
Jul 14, 2020
Merged

refine export cleaner (#2916) #2924

merged 1 commit into from
Jul 14, 2020

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jul 14, 2020 •
edited by lichunzhu
Loading

cherry-pick #2916 to release-1.1

What problem does this PR solve?

fix #2914

What is changed and how does it work?

when rclone meet doesn't exist error, make cleaner just ignore it.

Check List

Tests

  • Unit test
  • E2E test
  • Stability test
  • Manual test (add detailed scripts or steps below)
    test delete BR and dumpling's backup file and then delete backup CR.

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

Exit without error if we clean not found backup data

@lichunzhu @ti-srebot
cherry pick pingcap#2916 to release-1.1
62f859d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 14, 2020
Merged
@ti-srebot ti-srebot added this to the v1.1.3 milestone Jul 14, 2020
DanielZhangQD
DanielZhangQD approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanielZhangQD
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit 8f6ad50 into pingcap:release-1.1 Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielZhangQD DanielZhangQD DanielZhangQD approved these changes

Assignees

@lichunzhu lichunzhu

Labels
CanMerge status/LGT1
Projects
None yet
Milestone
v1.1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-srebot @DanielZhangQD @lichunzhu