Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure sysvars are lower case #35658

Closed
morgo opened this issue Jun 22, 2022 · 0 comments · Fixed by #35659
Closed

Ensure sysvars are lower case #35658

morgo opened this issue Jun 22, 2022 · 0 comments · Fixed by #35659
Assignees
@morgo
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@morgo
Copy link
Contributor

morgo commented Jun 22, 2022

Enhancement

There does not appear to be a test to validate sysvars are lower case. Code like this line should not be required:

tidb/session/bootstrap.go

Lines 2047 to 2048 in d4dc6b5

value := fmt.Sprintf(`("%s", "%s")`, strings.ToLower(k), vVal)
values = append(values, value)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@morgo morgo

Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

session, sessionctx/variable: ensure sysvars are always in lower case morgo/tidb
1 participant
@morgo