expression: implement vectorized evaluation for builtinCastRealAsJSONSig
#12673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
js00070
requested review from
qw4990,
Reminiscent,
SunRunAway and
XuHuaiyu
as code owners
Codecov Report
@@ Coverage Diff @@
## master #12673 +/- ##
===========================================
Coverage ? 80.4214%
===========================================
Files ? 461
Lines ? 107306
Branches ? 0
===========================================
Hits ? 86297
Misses ? 14882
Partials ? 6127 |
qw4990
reviewed
Oct 14, 2019
| if buf.IsNull(i) { | ||
| result.AppendNull() | ||
| } else { | ||
| result.AppendJSON(json.CreateBinary(f64s[i])) |
There was a problem hiding this comment.
Please add the comment above this line.
// FIXME: `select json_type(cast(1111.11 as json))` should return `DECIMAL`, we return `DOUBLE` now.```
SunRunAway
added
status/can-merge
|
Your auto merge job has been accepted, waiting for 12640, 12220, 12584 |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
implement vectorized evaluation for
builtinCastRealAsJSONSigmentioned at #12104What is changed and how it works?
about 35% faster
Check List
Tests