Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call For Participation: vectorize all JSON builtin functions #12104

Closed
27 tasks done
qw4990 opened this issue Sep 10, 2019 · 9 comments · Fixed by #16326
Closed
27 tasks done

Call For Participation: vectorize all JSON builtin functions #12104

qw4990 opened this issue Sep 10, 2019 · 9 comments · Fixed by #16326
Assignees
@qw4990
Labels
component/expression good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.

Comments

@qw4990
Copy link
Contributor

qw4990 commented Sep 10, 2019 •
edited
Loading

This issue is used to trace all vectorized JSON builtin functions, which is a part of #12058.

NOTE:

  1. Feel free to join us in the wg-vec-expr working group
  2. Please comment on this issue if you are working on any of the functions.

Note For Performance Challenge Teams: each PR on this issue has 50 score.

  • builtinCastIntAsJSONSig
  • builtinCastRealAsJSONSig
  • builtinCastDecimalAsJSONSig
  • builtinCastStringAsJSONSig
  • builtinCastDurationAsJSONSig
  • builtinCastTimeAsJSONSig
  • builtinCastJSONAsJSONSig
  • builtinCoalesceJSONSig
  • builtinCaseWhenJSONSig
  • builtinIfJSONSig @Reminiscent expression: implement vectorized evaluation for builtinIfJSONSig #12081
  • builtinIfNullJSONSig
  • builtinJSONExtractSig
  • builtinJSONSetSig
  • builtinJSONInsertSig
  • builtinJSONReplaceSig
  • builtinJSONRemoveSig
  • builtinJSONMergeSig
  • builtinJSONObjectSig
  • builtinJSONArraySig
  • builtinJSONArrayAppendSig
  • builtinJSONArrayInsertSig
  • builtinJSONSearchSig
  • builtinJSONKeysSig
  • builtinJSONKeys2ArgsSig
  • builtinJSONAnyValueSig
  • builtinNameConstJSONSig
  • builtinJSONUnquoteSig
@qw4990 qw4990 added type/enhancement The issue or PR belongs to an enhancement. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. component/expression labels Sep 10, 2019
@qw4990 qw4990 mentioned this issue Sep 10, 2019
Closed
@js00070
Copy link
Contributor

js00070 commented Oct 12, 2019 •
edited
Loading

working on
builtinJSONObjectSig
builtinCastIntAsJSONSig
builtinCastRealAsJSONSig
builtinJSONKeysSig

This was referenced Oct 12, 2019
Merged
Merged
Merged
Merged
@tsthght
Copy link
Contributor

tsthght commented Oct 17, 2019 •
edited
Loading

let me fix:
builtinCastDecimalAsJSONSig
builtinCastStringAsJSONSig
builtinCastDurationAsJSONSig
builtinCastTimeAsJSONSig
builtinCastJSONAsJSONSig
builtinCoalesceJSONSig

This was referenced Oct 17, 2019
Merged
Merged
Merged
Merged
Merged
@tsthght
Copy link
Contributor

tsthght commented Oct 18, 2019

let me fix:
builtinJSONAnyValueSig

@tsthght tsthght mentioned this issue Oct 18, 2019
Merged
This was referenced Oct 20, 2019
Merged
Merged
Merged
@tsthght tsthght mentioned this issue Oct 24, 2019
Closed
This was referenced Oct 24, 2019
Merged
Merged
@zhenghaoz
Copy link
Contributor

Let me fix:

  • builtinJSONSearchSig

@js00070 js00070 mentioned this issue Oct 28, 2019
Merged
@icditwang
Copy link
Contributor

let me fix :
builtinJSONArraySig

@pingyu
Copy link
Contributor

pingyu commented Nov 6, 2019

let me fix:
builtinJSONExtractSig

@pingyu pingyu mentioned this issue Nov 6, 2019
Merged
This was referenced Nov 7, 2019
Merged
Merged
@Darkone0
Copy link

Let me fix
builtinJSONInsertSig

@scarydemon2
Copy link

let me fix:
builtinJSONRemoveSig

@js00070
Copy link
Contributor

js00070 commented Nov 17, 2019

let me fix:
builtinJSONArrayAppendSig
builtinJSONArrayInsertSig

@js00070 js00070 mentioned this issue Nov 21, 2019
Merged
@shihongzhi shihongzhi mentioned this issue Dec 16, 2019
Merged
@zhaox1n zhaox1n mentioned this issue Mar 30, 2020
Merged
@qw4990 qw4990 mentioned this issue Apr 13, 2020
Merged
This was referenced Apr 14, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qw4990 qw4990

Labels
component/expression good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

expression: implement vectorized evaluation for JSONArrayAppend qw4990/tidb
9 participants
@pingyu @zz-jason @qw4990 @zhenghaoz @js00070 @tsthght @Darkone0 @icditwang @scarydemon2