Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for builtinJSONArrayInsertSig #13667

Merged
merged 3 commits into from
Nov 26, 2019
Merged

expression: implement vectorized evaluation for builtinJSONArrayInsertSig #13667

merged 3 commits into from
Nov 26, 2019

Conversation

js00070
Copy link
Contributor

@js00070 js00070 commented Nov 21, 2019

PCP #12104

What problem does this PR solve?

implement vectorized evaluation for builtinJSONArrayInsertSig

What is changed and how it works?

about 5% faster

goos: linux
goarch: amd64
pkg: github.com/pingcap/tidb/expression
BenchmarkVectorizedBuiltinJSONFunc/builtinJSONArrayInsertSig-VecBuiltinFunc-12               591           1983211 ns/op         1485645 B/op      10679 allocs/op
BenchmarkVectorizedBuiltinJSONFunc/builtinJSONArrayInsertSig-NonVecBuiltinFunc-12            583           2014990 ns/op         1487414 B/op      10677 allocs/op
PASS

Check List

Tests

  • Unit test

@js00070 js00070 requested a review from a team as a code owner November 21, 2019 10:10
@sre-bot
Copy link
Contributor

sre-bot commented Nov 21, 2019

Thanks for your contribution. If your PR get merged, you will be rewarded 50 points.

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Nov 21, 2019
@ghost ghost requested review from SunRunAway and wshwsh12 and removed request for a team November 21, 2019 10:10
@codecov
Copy link

codecov bot commented Nov 21, 2019 •
edited
Loading

Codecov Report

Merging #13667 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #13667   +/-   ##
===========================================
  Coverage   80.5938%   80.5938%           
===========================================
  Files           473        473           
  Lines        118143     118143           
===========================================
  Hits          95216      95216           
  Misses        15619      15619           
  Partials       7308       7308

SunRunAway
SunRunAway reviewed Nov 25, 2019
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, your implementation looks awsome!
Just a nickpick.

expression/builtin_json_vec_test.go Show resolved Hide resolved
SunRunAway
SunRunAway reviewed Nov 25, 2019
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 25, 2019
qw4990
qw4990 approved these changes Nov 26, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 26, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 26, 2019

/run-all-tests

@sre-bot sre-bot merged commit 445e302 into pingcap:master Nov 26, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 26, 2019

@js00070 complete task #12104 and get 50 score, currerent score 550.

XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@js00070 @XiaTianliang
expression: implement vectorized evaluation for builtinJSONArrayInser…
64e25e9 
…tSig (pingcap#13667)
@js00070 js00070 deleted the builtinJSONArrayInsertSig branch February 1, 2020 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SunRunAway SunRunAway SunRunAway left review comments

@qw4990 qw4990 qw4990 approved these changes

@wshwsh12 wshwsh12 Awaiting requested review from wshwsh12

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@js00070 @sre-bot @SunRunAway @qw4990