Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for builtinJSONSearchSig (#15859) #16382

Merged
merged 3 commits into from
Apr 15, 2020
Merged

expression: implement vectorized evaluation for builtinJSONSearchSig (#15859) #16382

merged 3 commits into from
Apr 15, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 15, 2020

cherry-pick #15859 to release-4.0

UCP #12104

What problem does this PR solve?

implement vectorized evaluation for builtinJSOSearchSig

What is changed and how it works?

BenchmarkVectorizedBuiltinJSONFunc/builtinJSONSearchSig-VecBuiltinFunc-12                           1408           1227651 ns/op         1138688 B/op      10240 allocs/op
BenchmarkVectorizedBuiltinJSONFunc/builtinJSONSearchSig-NonVecBuiltinFunc-12                        1076           1158112 ns/op         1138689 B/op      10240 allocs/op
BenchmarkVectorizedBuiltinJSONFunc/builtinJSONSearchSig-VecBuiltinFunc#01-12                         250           4691324 ns/op         2035133 B/op      34837 allocs/op
BenchmarkVectorizedBuiltinJSONFunc/builtinJSONSearchSig-NonVecBuiltinFunc#01-12                      249           4570834 ns/op         2035084 B/op      34837 allocs/op
BenchmarkVectorizedBuiltinJSONFunc/builtinJSONSearchSig-VecBuiltinFunc#02-12                         232           4946785 ns/op         2035053 B/op      34837 allocs/op
BenchmarkVectorizedBuiltinJSONFunc/builtinJSONSearchSig-NonVecBuiltinFunc#02-12                      288           5029420 ns/op         2035164 B/op      34838 allocs/op
BenchmarkVectorizedBuiltinJSONFunc/builtinJSONSearchSig-VecBuiltinFunc#03-12                         278           4720992 ns/op         2067925 B/op      35863 allocs/op
BenchmarkVectorizedBuiltinJSONFunc/builtinJSONSearchSig-NonVecBuiltinFunc#03-12                      241           4428660 ns/op         2068002 B/op      35862 allocs/op
BenchmarkVectorizedBuiltinJSONFunc/builtinJSONSearchSig-VecBuiltinFunc#04-12                         254           4857389 ns/op         2035008 B/op      34837 allocs/op
BenchmarkVectorizedBuiltinJSONFunc/builtinJSONSearchSig-NonVecBuiltinFunc#04-12                      247           4749373 ns/op         2035179 B/op      34838 allocs/op
BenchmarkVectorizedBuiltinJSONFunc/builtinJSONSearchSig-VecBuiltinFunc#05-12                         306           3730100 ns/op         1862828 B/op      21505 allocs/op
BenchmarkVectorizedBuiltinJSONFunc/builtinJSONSearchSig-NonVecBuiltinFunc#05-12                      302           3708237 ns/op         1862739 B/op      21504 allocs/op

Check List

Tests

  • Unit test

@sre-bot sre-bot requested a review from a team as a code owner April 15, 2020 02:39
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 15, 2020

/run-all-tests

@sre-bot sre-bot mentioned this pull request Apr 15, 2020
Merged
@sre-bot sre-bot added component/expression contribution This PR is from a community contributor. type/4.0-cherry-pick labels Apr 15, 2020
@ghost ghost requested a review from XuHuaiyu April 15, 2020 02:40
@sre-bot sre-bot requested review from qw4990 and wshwsh12 April 15, 2020 02:40
wshwsh12
wshwsh12 reviewed Apr 15, 2020
View reviewed changes
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

qw4990
qw4990 approved these changes Apr 15, 2020
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Apr 15, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 15, 2020

Sorry @qw4990, you don't have permission to trigger auto merge event on this branch.

@SunRunAway SunRunAway added status/can-merge Indicates a PR has been approved by a committer. and removed status/can-merge Indicates a PR has been approved by a committer. labels Apr 15, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 15, 2020

Your auto merge job has been accepted, waiting for 16378, 16277, 16076, 15866

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 15, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 15, 2020

@sre-bot merge failed.

@zz-jason zz-jason merged commit 331156d into pingcap:release-4.0 Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wshwsh12 wshwsh12 wshwsh12 left review comments

@qw4990 qw4990 qw4990 approved these changes

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees

@wshwsh12 wshwsh12

Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/4.0-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sre-bot @qw4990 @wshwsh12 @SunRunAway @zz-jason @zhaox1n