Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for JSONArrayAppend #16326

Merged
merged 10 commits into from
Apr 14, 2020
Merged

expression: implement vectorized evaluation for JSONArrayAppend #16326

merged 10 commits into from
Apr 14, 2020

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Apr 13, 2020

What problem does this PR solve?

Issue Number: close #12104

Problem Summary: implement vectorized evaluation for JSONArrayAppend

What is changed and how it works?

implement vectorized evaluation for JSONArrayAppend

BenchmarkVectorizedBuiltinJSONFunc/builtinJSONArrayAppendSig-VecBuiltinFunc-12               868           1280255 ns/op
BenchmarkVectorizedBuiltinJSONFunc/builtinJSONArrayAppendSig-NonVecBuiltinFunc-12            920           1284265 ns/op
BenchmarkVectorizedBuiltinJSONFunc/builtinJSONArrayAppendSig-VecBuiltinFunc#01-12            481           2462974 ns/op
BenchmarkVectorizedBuiltinJSONFunc/builtinJSONArrayAppendSig-NonVecBuiltinFunc#01-12         470           2485364 ns/op
BenchmarkVectorizedBuiltinJSONFunc/builtinJSONArrayAppendSig-VecBuiltinFunc#02-12            692           1786525 ns/op
BenchmarkVectorizedBuiltinJSONFunc/builtinJSONArrayAppendSig-NonVecBuiltinFunc#02-12         680           1751424 ns/op

Check List

Tests

  • Unit test

@qw4990 qw4990 requested a review from a team as a code owner April 13, 2020 12:16
@ghost ghost requested review from wshwsh12 and removed request for a team April 13, 2020 12:16
@qw4990 qw4990 requested a review from Reminiscent April 13, 2020 12:16
@codecov
Copy link

codecov bot commented Apr 13, 2020 •
edited
Loading

Codecov Report

Merging #16326 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #16326   +/-   ##
===========================================
  Coverage   80.4341%   80.4341%           
===========================================
  Files           506        506           
  Lines        136350     136350           
===========================================
  Hits         109672     109672           
  Misses        18157      18157           
  Partials       8521       8521

wshwsh12
wshwsh12 reviewed Apr 14, 2020
View reviewed changes
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wshwsh12 wshwsh12 added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 14, 2020
Reminiscent
Reminiscent approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@Reminiscent Reminiscent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Reminiscent Reminiscent added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 14, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 14, 2020

Your auto merge job has been accepted, waiting for 16117

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 14, 2020

/run-all-tests

1 similar comment
@sre-bot
Copy link
Contributor

sre-bot commented Apr 14, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Apr 14, 2020

@qw4990 merge failed.

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 14, 2020

/run-all-tests

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 14, 2020

/run-all-tests

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 14, 2020

/run-all-tests

1 similar comment
@qw4990
Copy link
Contributor Author

qw4990 commented Apr 14, 2020

/run-all-tests

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 14, 2020

/run-all-tests

@zz-jason
Copy link
Member

/run-sqllogic-test-2

@zz-jason
Copy link
Member

/run-check_dev_2

@zz-jason zz-jason merged commit 73cd983 into pingcap:master Apr 14, 2020
sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Apr 14, 2020
@qw4990 @sre-bot
expression: implement vectorized evaluation for `JSONArrayAppe… (ping…
3378112 
…cap#16326)
@sre-bot sre-bot mentioned this pull request Apr 14, 2020
Merged
@sre-bot
Copy link
Contributor

sre-bot commented Apr 14, 2020

cherry pick to release-4.0 in PR #16379

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wshwsh12 wshwsh12 wshwsh12 left review comments

@Reminiscent Reminiscent Reminiscent approved these changes

Assignees
No one assigned
Labels
component/expression status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Call For Participation: vectorize all JSON builtin functions
5 participants
@qw4990 @sre-bot @zz-jason @wshwsh12 @Reminiscent