Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for builtinJSONLengthSig #12982

Merged
merged 6 commits into from
Oct 30, 2019
Merged

expression: implement vectorized evaluation for builtinJSONLengthSig #12982

merged 6 commits into from
Oct 30, 2019

Conversation

js00070
Copy link
Contributor

@js00070 js00070 commented Oct 28, 2019

What problem does this PR solve?

implement vectorized evaluation for builtinJSONLengthSig at #12104

What is changed and how it works?

the performance is related to the test case. It will get faster from 1% to 6 times.

BenchmarkVectorizedBuiltinJSONFunc/builtinJSONLengthSig-VecBuiltinFunc-12                 300879              3545 ns/op               0 B/op          0 allocs/op
BenchmarkVectorizedBuiltinJSONFunc/builtinJSONLengthSig-NonVecBuiltinFunc-12               67075             17767 ns/op               0 B/op          0 allocs/op
BenchmarkVectorizedBuiltinJSONFunc/builtinJSONLengthSig-VecBuiltinFunc#01-12                2026            525188 ns/op          301371 B/op       2410 allocs/op
BenchmarkVectorizedBuiltinJSONFunc/builtinJSONLengthSig-NonVecBuiltinFunc#01-12             2137            554590 ns/op          301741 B/op       2410 allocs/op
BenchmarkVectorizedBuiltinJSONFunc/builtinJSONLengthSig-VecBuiltinFunc#02-12                2059            519725 ns/op          302338 B/op       2422 allocs/op
BenchmarkVectorizedBuiltinJSONFunc/builtinJSONLengthSig-NonVecBuiltinFunc#02-12             2120            540376 ns/op          302575 B/op       2422 allocs/op

Check List

Tests

  • Unit test

@js00070 js00070 requested a review from a team as a code owner October 28, 2019 16:19
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Oct 28, 2019
@ghost ghost requested review from XuHuaiyu and removed request for a team October 28, 2019 16:19
@js00070 js00070 changed the title implement vectorized evaluation for builtinJSONLengthSig expression: implement vectorized evaluation for builtinJSONLengthSig Oct 28, 2019
@codecov
Copy link

codecov bot commented Oct 29, 2019 •
edited
Loading

Codecov Report

Merging #12982 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #12982   +/-   ##
===========================================
  Coverage   80.1936%   80.1936%           
===========================================
  Files           468        468           
  Lines        109889     109889           
===========================================
  Hits          88124      88124           
  Misses        15058      15058           
  Partials       6707       6707

Reminiscent
Reminiscent reviewed Oct 29, 2019
View reviewed changes
Copy link
Contributor

@Reminiscent Reminiscent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Reminiscent Reminiscent added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 29, 2019
@js00070 js00070 requested a review from XuHuaiyu October 29, 2019 13:00
XuHuaiyu
XuHuaiyu reviewed Oct 30, 2019
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

XuHuaiyu
XuHuaiyu previously approved these changes Oct 30, 2019
View reviewed changes
@XuHuaiyu XuHuaiyu added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. status/can-merge Indicates a PR has been approved by a committer. labels Oct 30, 2019
@XuHuaiyu
Copy link
Contributor

@js00070 Please resolve the conflicts.

@qw4990
Copy link
Contributor

qw4990 commented Oct 30, 2019

@js00070 Friendly ping, please solve conflicts.

@js00070
Copy link
Contributor Author

js00070 commented Oct 30, 2019

@js00070 Friendly ping, please solve conflicts.

conflicts have been solved now.

@ngaut ngaut added the status/can-merge Indicates a PR has been approved by a committer. label Oct 30, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 30, 2019

/run-all-tests

@sre-bot sre-bot merged commit 877e194 into pingcap:master Oct 30, 2019
@js00070 js00070 deleted the JSONLength branch November 7, 2019 11:09
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@js00070 @XiaTianliang
expression: implement vectorized evaluation for builtinJSONLengthSig (
fa02e4e 
pingcap#12982)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reminiscent Reminiscent Reminiscent left review comments

@ngaut ngaut ngaut approved these changes

@XuHuaiyu XuHuaiyu XuHuaiyu left review comments

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@js00070 @XuHuaiyu @qw4990 @sre-bot @ngaut @Reminiscent