expression: implement vectorized evaluation for builtinJSONKeysSig
#12700
Conversation
ghost
requested review from
qw4990 and
XuHuaiyu
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #12700 +/- ##
===========================================
Coverage 79.8672% 79.8672%
===========================================
Files 462 462
Lines 105723 105723
===========================================
Hits 84438 84438
Misses 15010 15010
Partials 6275 6275 |
expression/builtin_json_vec.go
Outdated
|
|
||
| j = buf.GetJSON(i) | ||
| if j.TypeCode != json.TypeCodeObject { | ||
| result.AppendNull() |
There was a problem hiding this comment.
Should we return a json.ErrInvalidJSONData error in this case?
There was a problem hiding this comment.
yes, I should.
But I don't know whether or not it should return the error immediately in the for loop, or return the error at the end of the function?
There was a problem hiding this comment.
I also have the same confusion in other vectorized function
There was a problem hiding this comment.
Normally, if err != nil, we need to return error directly. But there are some cases where the error is reprocessed, it should recheck the err. For example, https://github.com/pingcap/tidb/blob/master/expression/builtin_arithmetic_vec.go#L88-L93
Reminiscent
added
status/can-merge
|
Your auto merge job has been accepted, waiting for 12751 |
|
/run-all-tests |
What problem does this PR solve?
implement vectorized
builtinJSONKeysSigmentioned here #12104What is changed and how it works?
about 10% faster
Check List
Tests