planner: resolveFromPlan when tblName.colName exists in having clause #18349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuHuaiyu
changed the title
XuHuaiyu
requested review from
winoros,
qw4990 and
eurekaka
and removed request for
hanfei1991
|
/run-all-tests |
|
@eurekaka,Thanks for your review. |
Codecov Report
@@ Coverage Diff @@
## master #18349 +/- ##
===========================================
Coverage 79.3923% 79.3923%
===========================================
Files 540 540
Lines 144665 144665
===========================================
Hits 114853 114853
Misses 20524 20524
Partials 9288 9288 |
|
/merge |
|
/merge |
|
Sorry @eurekaka, you don't have permission to trigger auto merge event on this branch. The number of |
ti-srebot
approved these changes
Jul 8, 2020
|
@lzmhhh123,Thanks for your review. |
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jul 8, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-3.0 in PR #18432 |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jul 8, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-3.1 in PR #18433 |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jul 8, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #18434 |
XuHuaiyu
pushed a commit
that referenced
this pull request
Jul 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #18384
Problem Summary:
What is changed and how it works?
What's Changed:
For SQL like
select a+1 from t having t.a, we need to resolve it from the plan and select fields both.How it Works:
Related changes
Check List
Tests
Side effects
N/A
Release note
select a from t having t.a