Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: deprecate allow-auto-random option #18618

Merged
merged 5 commits into from
Jul 16, 2020
Merged

config: deprecate allow-auto-random option #18618

merged 5 commits into from
Jul 16, 2020

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Jul 16, 2020 •
edited
Loading

What problem does this PR solve?

Fix pingcap/tiup#598

What is changed and how it works?

Proposal: xxx

What's Changed: Add allow-auto-random to deprecate config option to avoid config-check failed.

Related changes

Check List

Tests

  • Unit test
  • Integration test
  • Manual test

Now it will return 0 if we provide allow-auto-random configuration.

$ ./bin/tidb-server -config ~/.config/tidb/config.toml.example -config-check true
config file /home/tangenta/.config/tidb/config.toml.example contained unknown configuration options: experimental.allow-auto-random
config check successful

Side effects

Release note

  • No release note.

bb7133
bb7133 reviewed Jul 16, 2020
View reviewed changes
config/config.toml.example Outdated Show resolved Hide resolved
config/config.go Outdated Show resolved Hide resolved
@tangenta
Copy link
Contributor Author

/run-all-tests

lonng
lonng reviewed Jul 16, 2020
View reviewed changes
Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should add a diagnostic rule for it, and warn users if this configuration is configured explicity.

jackysp
jackysp reviewed Jul 16, 2020
View reviewed changes
config/config.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 16, 2020 •
edited
Loading

Codecov Report

Merging #18618 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #18618   +/-   ##
===========================================
  Coverage   79.4850%   79.4850%           
===========================================
  Files           540        540           
  Lines        145723     145723           
===========================================
  Hits         115828     115828           
  Misses        20557      20557           
  Partials       9338       9338

@tangenta tangenta changed the title config: add allow-auto-random option and deprecate it config: deprecate allow-auto-random option Jul 16, 2020
jackysp
jackysp reviewed Jul 16, 2020
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 16, 2020
bb7133
bb7133 approved these changes Jul 16, 2020
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jul 16, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 16, 2020
@bb7133
Copy link
Member

bb7133 commented Jul 16, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 16, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@tangenta merge failed.

@tangenta
Copy link
Contributor Author

/run-integration-copr-test

@tangenta
Copy link
Contributor Author

/run-check_dev_2

[2020-07-16T04:09:59.409Z] ----------------------------------------------------------------------
[2020-07-16T04:09:59.409Z] FAIL: http_handler_test.go:1058: HTTPHandlerTestSuite.TestAllServerInfo
[2020-07-16T04:09:59.409Z] 
[2020-07-16T04:09:59.409Z] http_handler_test.go:1080:
[2020-07-16T04:09:59.409Z]     c.Assert(ok, Equals, true)
[2020-07-16T04:09:59.409Z] ... obtained bool = false
[2020-07-16T04:09:59.409Z] ... expected bool = true

@bb7133 bb7133 merged commit 38621d2 into pingcap:master Jul 16, 2020
@tangenta
Copy link
Contributor Author

/run-cherry-picker

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 16, 2020
@ti-srebot
cherry pick pingcap#18618 to release-4.0
1f47373 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 16, 2020
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #18623

bb7133 pushed a commit that referenced this pull request Jul 16, 2020
@ti-srebot
config: deprecate allow-auto-random option (#18618) (#18623)
f11b3cc
@tangenta tangenta mentioned this pull request Jul 16, 2020
Closed
@bb7133 bb7133 mentioned this pull request Feb 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lonng lonng lonng left review comments

@jackysp jackysp jackysp left review comments

@bb7133 bb7133 bb7133 approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

Assignees
No one assigned
Labels
component/config status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tiup cluster upgrade config check failed
5 participants
@tangenta @bb7133 @ti-srebot @lonng @jackysp