Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: deprecate allow-auto-random option (#18618) #18623

Merged
merged 2 commits into from
Jul 16, 2020
Merged

config: deprecate allow-auto-random option (#18618) #18623

merged 2 commits into from
Jul 16, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #18618 to release-4.0

What problem does this PR solve?

Fix pingcap/tiup#598

What is changed and how it works?

Proposal: xxx

What's Changed: Add allow-auto-random to deprecate config option to avoid config-check failed.

Related changes

Check List

Tests

  • Unit test
  • Integration test
  • Manual test

Now it will return 0 if we provide allow-auto-random configuration.

$ ./bin/tidb-server -config ~/.config/tidb/config.toml.example -config-check true
config file /home/tangenta/.config/tidb/config.toml.example contained unknown configuration options: experimental.allow-auto-random
config check successful

Side effects

Release note

  • No release note.

@ti-srebot
cherry pick pingcap#18618 to release-4.0
1f47373 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Jul 16, 2020
Merged
@ti-srebot ti-srebot added this to the v4.0.3 milestone Jul 16, 2020
@tangenta
Copy link
Contributor

/run-all-tests

bb7133
bb7133 reviewed Jul 16, 2020
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 16, 2020
jackysp
jackysp reviewed Jul 16, 2020
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 16, 2020
@bb7133 bb7133 merged commit f11b3cc into pingcap:release-4.0 Jul 16, 2020
@bb7133 bb7133 mentioned this pull request Jul 23, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 left review comments

@jackysp jackysp jackysp approved these changes

@lonng lonng Awaiting requested review from lonng

Assignees

@tangenta tangenta

Labels
component/config status/LGT2 Indicates that a PR has LGTM 2. type/4.0-cherry-pick
Projects
None yet
Milestone
v4.0.3
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-srebot @tangenta @bb7133 @jackysp