planner: add more test cases for join order hint #34740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
� Conflicts: � planner/core/rule_join_reorder.go � planner/core/rule_join_reorder_greedy.go
…-leading-hint � Conflicts: � planner/core/rule_join_reorder.go � planner/core/rule_join_reorder_greedy.go
…-leading-hint � Conflicts: � planner/core/rule_join_reorder.go
…Cases � Conflicts: � planner/core/logical_plan_builder.go � planner/core/rule_join_reorder.go � planner/core/rule_join_reorder_test.go � planner/core/testdata/join_reorder_suite_in.json � planner/core/testdata/join_reorder_suite_out.json
|
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/e5d815748adec16f7362b118b2078780dcc0efc7 |
Reminiscent
commented
May 18, 2022
Reminiscent
commented
May 18, 2022
| "Warning": null | ||
| }, | ||
| { | ||
| "SQL": "select /*+ leading(t2) hash_join(t1) */ * from t, t1, t2, t3 where t.a = t1.a and t1.b=t2.b;", |
There was a problem hiding this comment.
It needs to be marked in the document. If the join algorithm hint is set, the join node will be skipped when splitting the join group
Reminiscent
commented
May 18, 2022
winoros
approved these changes
May 19, 2022
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: ed7f2c1
|
ti-chi-bot
added
the
status/can-merge
|
/run-mysql-test |
|
/merge |
|
/run-mysql-test |
TiDB MergeCI notify🔴 Bad News! [1] CI still failing after this pr merged.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #29932
Problem Summary:
add more test cases for join order hint and add some warning messages for some forbidden cases,
What is changed and how it works?
add more test cases for join order hint and add some warning messages for some forbidden cases,
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.