Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: refine history job code #35967

Merged
merged 4 commits into from
Jul 6, 2022
Merged

ddl: refine history job code #35967

merged 4 commits into from
Jul 6, 2022

Conversation

xiongjiwei
Copy link
Contributor

What problem does this PR solve?

refine history job code

  • rename function name
  • use iterator implement all the history job relate function

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 5, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Defined2014
  • hawkingrei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 5, 2022
@xiongjiwei xiongjiwei added the skip-issue-check Indicates that a PR no need to check linked issue. label Jul 5, 2022
@xiongjiwei xiongjiwei marked this pull request as ready for review July 5, 2022 13:09
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 5, 2022
@bb7133 bb7133 closed this Jul 5, 2022
@bb7133 bb7133 reopened this Jul 5, 2022
@xiongjiwei
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 5, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 5, 2022
@hawkingrei hawkingrei self-requested a review July 6, 2022 02:54
Defined2014
Defined2014 reviewed Jul 6, 2022
View reviewed changes
ddl/ddl.go Outdated Show resolved Hide resolved
meta/meta_test.go Show resolved Hide resolved
@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jul 6, 2022
@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 6, 2022
xhebox
xhebox approved these changes Jul 6, 2022
View reviewed changes
Copy link
Contributor

@xhebox xhebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can use iterator to optimize the get ddl history HTTP api, like paging.

@xiongjiwei
Copy link
Contributor Author

I think we can use iterator to optimize the get ddl history HTTP api, like paging.

that is another job

@sre-bot
Copy link
Contributor

sre-bot commented Jul 6, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/f5e73b780c11b49bf173c686ae669f4a2133527e

@xiongjiwei
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c539af7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 6, 2022
@ti-chi-bot ti-chi-bot merged commit 637d00c into pingcap:master Jul 6, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 6, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/common-test 🟥 failed 1, success 11, total 12 13 min New failing
idc-jenkins-ci-tidb/tics-test 🔴 failed 1, success 0, total 1 12 min Existing failure
idc-jenkins-ci/integration-cdc-test ✅ all 35 tests passed 26 min Fixed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 11 tests passed 21 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 7 min 13 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 6 min 22 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 6 min 2 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 2 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 2 min 52 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

morgo added a commit to morgo/tidb that referenced this pull request Jul 6, 2022
@morgo
Merge remote-tracking branch 'upstream/master' into improve-skip-init
10c7409 
* upstream/master: (77 commits)
  infoschema: add a simply store for DM's SchemaTracker (pingcap#35954)
  planner: refactor "access object" related logic and prepare for binary plan (pingcap#35890)
  telemetry: Initialize telemetry asynchronously (pingcap#35898)
  sessionctx/variable: convert TiDBLogFileMaxDays and TiDBConfig to ScopeInstance (pingcap#35733)
  session, sessionctx/variable: ensure sysvars are always in lower case (pingcap#35659)
  *: add telemetry support for multi-schema change (pingcap#35977)
  topsql: compress plan instead of dropping it (pingcap#35973)
  *: use pdqsort to improve sort performance (pingcap#34404)
  ddl: refine GetDDLInfo function (pingcap#35969)
  *: Make the code cleaner in session.ExecutePreparedStmt (pingcap#35943)
  ddl: remove `onDropIndexes` (pingcap#35960)
  ddl: refine history job code (pingcap#35967)
  sessionctx,kv,planner: add system variable for fine_grained_shuffle (pingcap#35256)
  *: change remote cache (pingcap#35968)
  *: enable gosec (pingcap#35873)
  plancodec: fix a miss case in conversion (pingcap#35957)
  ddl: support drop indexes for multi-schema change (pingcap#35883)
  pdutil: fix unstable test TestPauseSchedulersByKeyRange (pingcap#35949)
  br: optimize communication with tikv stores. pingcap#31722 (pingcap#35147)
  txn: rename snapshot related methods in txnManager. (pingcap#35912)
  ...
@xiongjiwei xiongjiwei deleted the ref-history branch September 23, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhebox xhebox xhebox approved these changes

@Defined2014 Defined2014 Defined2014 approved these changes

@tangenta tangenta Awaiting requested review from tangenta

@hawkingrei hawkingrei Awaiting requested review from hawkingrei

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@xiongjiwei @ti-chi-bot @sre-bot @hawkingrei @xhebox @Defined2014 @bb7133