Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support sqrt,floor,ceil pushdown #2090

Merged
merged 6 commits into from
Jun 4, 2021
Merged

support sqrt,floor,ceil pushdown #2090

merged 6 commits into from
Jun 4, 2021

Conversation

chAngeZhaoZhanBo
Copy link
Contributor

What problem does this PR solve?

Related to #1901

Problem Summary:

Pushdown sqrt ceil floor to tiflash and add RoundingDecimalToInt support

What is changed and how it works?

Proposal: xxx

What's Changed:

  • FunctionsRound.h to support decimal related rounding
  • DAGUtils.cpp to modify scalar_func_map to update pushdown list

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

Release note

  • No release note

@chAngeZhaoZhanBo
Copy link
Contributor Author

/run-all-tests

@chAngeZhaoZhanBo
Copy link
Contributor Author

/run-all-tests

leiysky
leiysky approved these changes Jun 4, 2021
View reviewed changes
Copy link
Contributor

@leiysky leiysky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 4, 2021
@leiysky
Copy link
Contributor

leiysky commented Jun 4, 2021

/run-all-tests

@chAngeZhaoZhanBo chAngeZhaoZhanBo merged commit 8d5d0b1 into pingcap:master Jun 4, 2021
@LittleFall LittleFall deleted the sqrt-ceil-floor-pushdown-2 branch June 6, 2021 05:18
@LittleFall LittleFall mentioned this pull request Jun 6, 2021
Closed
@leiysky leiysky added component/expression needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 type/enhancement The issue or PR belongs to an enhancement. labels Jun 17, 2021
@leiysky
Copy link
Contributor

leiysky commented Jun 17, 2021

/run-cherry-picker

@ti-srebot ti-srebot mentioned this pull request Jun 17, 2021
Closed
@ti-srebot
Copy link
Collaborator

cherry pick to release-5.0 in PR #2196

@chAngeZhaoZhanBo chAngeZhaoZhanBo mentioned this pull request Jun 21, 2021
Merged
This was referenced Aug 5, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leiysky leiysky leiysky approved these changes

Assignees
No one assigned
Labels
component/expression needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 status/LGT1 Indicates that a PR has LGTM 1. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chAngeZhaoZhanBo @leiysky @ti-srebot