Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Math func pushdown (#2217) #2580

Closed

Conversation

ti-srebot
Copy link
Collaborator

@ti-srebot ti-srebot commented Aug 5, 2021

cherry-pick #2217 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tics repo:
git pr https://github.com/pingcap/tics/pull/2580

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tics.git pr/2580:release-5.0-df296ed35746

What problem does this PR solve?

Related to #1901

Problem Summary:

Pushdown all mathematics functions to tiflash(except sqrt, ceil, floor and round because they've been already supported by #2090)

What is changed and how it works?

Proposal: xxx

What's Changed:

  • FunctionsMath.h to impl log, ln, log2, log10, exp, pow, sign, degrees, radians
  • FunctionsMath.cpp to register
  • FunctionsStringMath.h to impl crc32 and conv
  • FunctionsStringMath.cpp to register
  • DAGUtils.cpp to modify scalar_func_map to update pushdown list
  • math_func.test to test

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

Release note

  • No release note

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 5, 2021
@ti-srebot ti-srebot added CHERRY-PICK cherry pick component/expression type/enhancement The issue or PR belongs to an enhancement. labels Aug 5, 2021
@ti-srebot ti-srebot added this to the v5.0.4 milestone Aug 5, 2021
@windtalker
Copy link
Contributor

close as it is not needed in 5.0.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CHERRY-PICK cherry pick component/expression type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants