Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For wrong alignment of the leaves of dendrogram #1180

Closed
wants to merge 3 commits into from
Closed

For wrong alignment of the leaves of dendrogram #1180

wants to merge 3 commits into from

Conversation

444thLiao
Copy link
Contributor

No description provided.

@444thLiao
Update _dendrogram.py
3c4b179
@444thLiao
Merge pull request #1 from 444thLiao/444thLiao-patch-1
b1b2c20 
Update _dendrogram.py wrapper wrong dendrogram leaves method.
@444thLiao 444thLiao mentioned this pull request Sep 17, 2018
Closed
@jonmmease
Copy link
Contributor

Hi @444thLiao ,

Thanks for the contribution. There are a couple of things we'll need in order to move forward.

  1. Please merge this with the current master branch and then push your changes to update the pull request. This will invoke our current set of integration tests.

  2. Please include a small code example in this pull request that demonstrates the current problem and your updated solution. Format the code in a fenced code block) and include the before and after images of the resulting plot.

Thanks!

@444thLiao 444thLiao mentioned this pull request Sep 18, 2018
Merged
@jonmmease
Copy link
Contributor

Closed in favor of #1186

@jonmmease jonmmease closed this Sep 20, 2018
@jonmmease jonmmease mentioned this pull request Sep 28, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@444thLiao @jonmmease