Update _dendrogram.py #894
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At previous version of dendrogram script, it use easy way to detect a node whether a leaves. But in our daily work, we will meet situation like this graph show. It will make the branch become all 0. Including the parent branches. So it can't use this easy way.
Need to be cautious: It is not the leaves 'U-shape' is all zeros. It also have some parent branches 'U- shape' is all zeros. (zeros I mean is there yvalus)
But I don't have much time to fix it. So I just add a wrapper to fix this. I have checked scipy doc. It is a safe way to build a new tickvals. So I build it in this way.