Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support repo-less execution + refactor #695

Merged

Conversation

illusional
Copy link
Contributor

@illusional illusional commented Jul 29, 2024

  • Make repo + commit optional (with use of --skip-repo-checkout flag)
  • Refactor the server into better param extraction, and then application.
  • Split server/main.py into ar.py and config.py

Issue: https://cpg-populationanalysis.atlassian.net/browse/SET-92

Repo-less execution: https://batch.hail.populationgenomics.org.au/batches/474490/jobs/1

Copy link
Contributor

@nevoodoo nevoodoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my very limited knowledge, it LGTM!

Copy link
Contributor

@dancoates dancoates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just a couple of little things

analysis_runner/cli_analysisrunner.py Outdated Show resolved Hide resolved
server/ar.py Outdated Show resolved Hide resolved
illusional and others added 4 commits August 6, 2024 07:46
* Actually call the job

* Refactor cromwell endpoint

---------

Co-authored-by: Michael Franklin <illusional@users.noreply.github.com>
…into SET-92-allow-the-analysis-runner-to-run-without-a-repository
@illusional illusional merged commit 2fa25f2 into main Aug 22, 2024
4 checks passed
@illusional illusional deleted the SET-92-allow-the-analysis-runner-to-run-without-a-repository branch August 22, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants