Don't add comment printing command if there are no comments to print #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When get_batch_comments() returns [], this invoked `job.command('')`
which leads to a syntax error in the eventual job's shell script.
MattWellie
approved these changes
Sep 23, 2024
|
Turns out the same problem in non-Cromwell runs was only fixed recently in 3.1.0, and deploying that failed ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #695, which made this check in server/ar.py but neglected it in server/cromwell.py:
When
get_batch_comments()returns[], this invokedjob.command('')which leads to a syntax error in the eventual job's shell script.