Fixed crash when using face meshes and element IDs don't start to 0 #95

boris-martin · 2022-05-16T10:19:26Z

Context

Since the merge of #91, simulations using face meshes can use either tetrahedra elements or hexaedral elements, instead of just tetrahedra. (It is however still limited to cases with only one type)
Current implementation finds whether tetra or hex are used by looking at the type of the first element (since we assume they're all the same). However, CalculiX can use meshes where there is no first element, in the sense that indices can start after 0. (See mesh of the heat exchanger tutorial for instance)
When this occurs, we find a "null" element and return an error because of the use of an unsupported element.

Proposed fix

Iterate over all elements until a non-null element is found, and use this one to decide between tetra and hexas.

Reproduce the bug

Try to run heat exchanger tutorial with current develop branch: it outputs an error because of unsupported element.

…t start to 0

adapter/CCXHelpers.h

adapter/PreciceInterface.c

IshaanDesai

Had a brief look, did not try to run the heat-exchanger tutorial. Running that tutorial would be a good check for this right?

Co-authored-by: Ishaan Desai <ishaandesai@gmail.com>

boris-martin · 2022-05-16T16:01:22Z

@IshaanDesai thanks for the review!
Yes, running the heat exchanger is a good test and it worked for me. (it still suffers from the "crash at t=5" issue we recently reopened, but without this PR it crashes earlier at initalization time)

Co-authored-by: Ishaan Desai <ishaandesai@gmail.com>

…t to 0 (#95)" This reverts commit 9cfc0cf.

…t to 0 (#95)" (#96) This reverts commit 9cfc0cf.

* Improved error message (for missing mesh) (#88) * Added error message for missing faces mesh * Improved error message for missing nodes mesh * 2D simulations major overhaul (#92) Fixed 2D simulations being unusable with Temperature BC. Arbitrary number of elements on the Z-axis is now allowed and handled assuming data independant of the Z-axis. * Added Pressure ExchangeData, hexaedral elements and Modal Dynamic Modus (#91) * Added Pressure ExchangeData, hexaedral elements and Modal Dynamic Modus * Update dyna_precice.c Co-authored-by: Matthias Freimuth <matzefreim@gmail.com> Co-authored-by: Boris Martin <84379125+boris-martin@users.noreply.github.com> * format * Added warning of broken implicit coupling when using modal dynamic simulations * Fixed mesh configuration 2D coupling with Face meshes (#94) * Fixed mesh config for face mesh * Removed dead code * Fixed missing include * Fixed crash when using face meshes and element IDs don't start to 0 (#95) * Fixed crashing simulation when using face meshes and element IDs don't start to 0 * Typo Co-authored-by: Ishaan Desai <ishaandesai@gmail.com> * Typo Co-authored-by: Ishaan Desai <ishaandesai@gmail.com> * Typo Co-authored-by: Ishaan Desai <ishaandesai@gmail.com> * Update adapter/CCXHelpers.h Co-authored-by: Ishaan Desai <ishaandesai@gmail.com> * format * reverted fallow-argument-mismatch * format Co-authored-by: Ishaan Desai <ishaandesai@gmail.com> * Revert "Fixed crash when using face meshes and element IDs don't start to 0 (#95)" (#96) This reverts commit 9cfc0cf. * Update packaging script to Ubuntu 22.04 LTS (#98) * added ubuntu 22.04 to the list of OSes in Github action * updated to 2 Ubuntu LTS only, added fflags * fixed wrong distribution name * added preivous Ubuntu non-LTS * fixd missing os * typo * removed non LTS * Fixed face mesh config(correct PR) (#97) * Fixed crashing simulation when using face meshes and element IDs don't start to 0 * Typo Co-authored-by: Ishaan Desai <ishaandesai@gmail.com> * Typo Co-authored-by: Ishaan Desai <ishaandesai@gmail.com> * Typo Co-authored-by: Ishaan Desai <ishaandesai@gmail.com> * Update adapter/CCXHelpers.h Co-authored-by: Ishaan Desai <ishaandesai@gmail.com> Co-authored-by: Ishaan Desai <ishaandesai@gmail.com> * format * format * restored script * Fixed implicit coupling in modal dynamic simulation. (#99) * Fixed missing checkpointing * fixed extra output in implicit coupling * removed deprecated warnings * Fixed crash when freeing unused pointers (#102) * init NULL pointers * Enable Static Step for FSI (#101) * Update ccx_2.19.c Enable basic Static Step * Update ccx_2.19.c * Update ccx_2.19.c * Add error messages when reading invalid data in modal dynamic simulations (#103) * registering modal dynamic * added forbidden reading types to modal dynamic sims * added actual error * Update adapter/PreciceInterface.c Co-authored-by: Gerasimos Chourdakis <makishourdakis@gmail.com> * Update adapter/PreciceInterface.h Co-authored-by: Gerasimos Chourdakis <makishourdakis@gmail.com> Co-authored-by: Gerasimos Chourdakis <makishourdakis@gmail.com> * basic infrastructure for proper checkpointingin dyna_precice * seemingly working implict + subcycling modal dynamic simulations * Prototype output buffer * added C API * added missing function * improved Buffer * Actual usage of the buffer, seemingly working * added short description of the buffer mechanism * cleanup * refactoring * format * removed dead code * renamed for consistency * no longer asking for length when loading data * cleanup * documentation * removed apparently useless memcpy (#104) * Make read/write data name parsing consistent (#108) * Update for CalculiX v2.20 (#109) Co-authored-by: Boris Martin <84379125+boris-martin@users.noreply.github.com> Co-authored-by: MatthiasFreimuth <34025080+MatthiasFreimuth@users.noreply.github.com> Co-authored-by: Matthias Freimuth <matzefreim@gmail.com> Co-authored-by: Boris Martin <boris.martin.be@gmail.com> Co-authored-by: Ishaan Desai <ishaandesai@gmail.com> Co-authored-by: Kyle Davis <kyle.davis@ipvs.uni-stuttgart.de>

Fixed crashing simulation when using face meshes and element IDs don'…

b6d5dcb

…t start to 0

boris-martin added the bug label May 16, 2022

boris-martin requested review from KyleDavisSA and IshaanDesai May 16, 2022 10:19

boris-martin changed the base branch from master to develop May 16, 2022 10:26