Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 3.1.0 #1985

Merged
merged 78 commits into from
Apr 5, 2024
Merged

Release 3.1.0 #1985

merged 78 commits into from
Apr 5, 2024

Conversation

fsimonis
Copy link
Member

@fsimonis fsimonis commented Mar 28, 2024

How to work with this template

  • assign a release manager, who takes care of the process
  • assign each point below to a responsible person, before you continue. Use @member.

Only the release manager should update this post (even tickboxes, due to race conditions in editing). Everybody else should comment on the PR with the progress.

Pre-PR steps

  • Look over PRs and Issues without an assigned version. (all)
  • Look over entries in docs/changelog) (all)
    • Add missing entries, if necessary
    • Fix wording and tense
  • Make sure you have the latest develop and main branches locally.
  • Merge main to develop ( This should result in no commits )
  • Check code base w.r.t code formatting (run precice/tools/formatting/check-format) and reformat if required (run precice/tools/formatting/format-all)
  • Update the list of operating systems for the package generation in .github/workflows/release.yml
  • Create branch release-vX.Y.Z from develop. If needed, git rebase develop.
  • Run tools/releasing/bumpversion.sh MAJOR.MINOR.PATCH to bump the version
  • Look over the updated CHANGELOG.md of the release branch (all)
    • Check for merged lines
    • Add things, if necessary
    • Fix wording and tense
    • Sort the entries lexicographically
    • Extract summary
  • Verify the version changes in:
    • CHANGELOG
    • CMakeLists.txt
    • tools/releasing/packaging/debian/changelog
  • Commit the version bump
  • Push the release branch to the precice repository
  • Prepare independent releases

Step by step guide

  • Open PR from release-vX.Y.Z to main (use this template)
  • Do regression tests using the release branch (specific revision) list below ⬇️ (all)
  • Fix potential problems in develop (all)
  • Rebase the release branch on develop (all)
  • Commit the version bump
  • Update documentation (all)
  • Approve the PR with at least two reviews (all)
  • Merge PR to main ( use git merge --no-ff release-vX.Y.Z )
  • Tag release on main vX.Y.Z and verify by running git describe --tags
  • Merge back to develop and verify by running git describe --tags
  • Triple check that you haven't messed anything up. (You can always discard local changes)
  • Push main and push the vX.Y.Z tag
  • Push develop
  • Wait for the release pipeline
  • Write release text
  • Publish the GitHub release

Regression Tests

Use the following branches:

  • precice release-v3.1.0
  • pyprecice python-bindings-v3.1.0.0
  • matlab-bindings matlab-bindings-v3.1.0.0
  • rest main(master)

Run all these tests manually on your system. If you succeed, please write a comment with the revisions of the components that you used below. Example: #507 (comment) and update the table.

State Success Failure Skipped
Write :o: :x: :fast_forward:
Read
State Tester Test
@MakisH quickstart fluid-openfoam - solid-cpp
@MakisH flow-over-heated-plate all
@MakisH perpendicular-flap fluid-openfoam - solid-dune
@MakisH perpendicular-flap fluid-nutils - solid-calculix
@MakisH perpendicular-flap fluid-openfoam - solid-dealii
@MakisH perpendicular-flap fluid-su2 - solid-fenics
@fsimonis heat-exchanger-simplified fluid-(bottom+top)-openfoam - solid-calculix
@IshaanDesai two-scale-heat-conduction macro-nutils - micro-nutils
#1984 elastic-tube-1d fluid-cpp - solid-python
@MakisH precice/tutorials#509 elastic-tube-3d fluid-openfoam - solid-calculix
@uekerman breaking-dam-2d fluid-openfoam - solid-calculix
@fsimonis flow-around-controlled-moving-cylinder controller-fmi - fluid-openfoam

Post-release

  • Update version specific documentation
  • Flag Arch Linux AUR package and dependants as out-of-date.
  • Update Spack recipe
  • Update pyprecice Spack
  • Update Website:

Release new version for bindings (to ensure compatibility with newest preCICE version)

Marketing

This will be included into the marketing of the distribution.

Misc

To open a new PR with this template, use this PR template query

fsimonis and others added 30 commits February 1, 2024 12:00
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3 to 4.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@v3...v4)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
* Change develop dockerimage to base on blank ubuntu:22.04

* Rename precice:develop to precice:nightly and restructure

* Fix release pipeline dependencies

* Rename docker workflows
@fsimonis fsimonis added the bug preCICE does not behave the way we want and we should look into it (and fix it if possible) label Mar 28, 2024
@fsimonis fsimonis added this to the Version 3.1.0 milestone Mar 28, 2024
@fsimonis fsimonis self-assigned this Mar 28, 2024
@fsimonis fsimonis changed the title Bump version to 3.1.0 Release 3.1.0 Mar 28, 2024
@fsimonis
Copy link
Member Author

We already did a pretty extensive testing of the elastic-tube-1d in #1984. The elastic-tube-1d for example took overall less iterations compared to v3.0.0.

The improved numerical accuracy may impact other tutorials too.

@fsimonis fsimonis changed the base branch from develop to main March 28, 2024 17:36
@MakisH
Copy link
Member

MakisH commented Apr 2, 2024

In the perpendicular-flap, the watchpoint plots look macroscopically the same for OpenFOAM-CalculiX and SU2-deal.II:

watchpoints-openfoam-calculix

watchpoints-su2-dealii

They still differ in the last digits, though. For example, for OpenFOAM-CalculiX:

  Time  Coordinate0  Coordinate1  Displacement0  Displacement1  Force0  Force1
- 1.00000000e-02   0.00000000e+00   1.00000000e+00   1.40208926e-03   2.53734422e-06   2.03655843e+01  -1.52019984e+01
- 5.00000000e+00   0.00000000e+00   1.00000000e+00   4.74162578e-02   7.18069885e-05   7.15678920e+00   1.30275199e+01
+ 1.00000000e-02   0.00000000e+00   1.00000000e+00   1.40209082e-03   2.53740150e-06   2.03655856e+01  -1.52020001e+01
+ 5.00000000e+00   0.00000000e+00   1.00000000e+00   4.74080199e-02   7.18246368e-05   7.15671092e+00   1.30274986e+01

openfoam-calculix-v3.0.0.log
openfoam-calculix-v3.1.0.log
su2-dealii-v3.0.0.log
su2-dealii-v3.1.0.log

@davidscn davidscn mentioned this pull request Apr 2, 2024
9 tasks
@MakisH
Copy link
Member

MakisH commented Apr 3, 2024

More perpendicular-flap tests in precice/tutorials#507

@MakisH
Copy link
Member

MakisH commented Apr 3, 2024

Some results for elastic-tube-3d: precice/tutorials#509

I don't have results with v3.0.0 or v2.5.0, besides the watchpoint plot in the tutorial.

@MakisH
Copy link
Member

MakisH commented Apr 4, 2024

I have also tested the Quickstart and the flow-over-heated-plate with all combinations: precice/tutorials#510

as well as the multiple-perpendicular-flaps: precice/tutorials#511

I have not at any point checked/compared iteration numbers.

@uekerman
Copy link
Member

uekerman commented Apr 4, 2024

breaking-dam-2d runs and looks meaningful.

  • openfoam adapter v1.3.0
  • calculix adapter 2b5802e
  • tutorials: 3485e524

@fsimonis
Copy link
Member Author

fsimonis commented Apr 4, 2024

flow-around-controlled-moving-cylinder works

image

image

image

image

@fsimonis
Copy link
Member Author

fsimonis commented Apr 5, 2024

The heat-exchanger-simplified works precice/tutorials#513

@fsimonis fsimonis marked this pull request as ready for review April 5, 2024 10:00
@fsimonis fsimonis merged commit 345be92 into main Apr 5, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug preCICE does not behave the way we want and we should look into it (and fix it if possible)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants