Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update multiple-perpendicular-flaps picture and documentation #511

Merged
merged 4 commits into from
Apr 4, 2024

Conversation

MakisH
Copy link
Member

@MakisH MakisH commented Apr 3, 2024

@davidscn had some issues reproducing this picture at some point, I hope that the additional details and the missing scaling factor helps.

This also changes the threshold for the size check to 750KB. I think that, back in the day, we set it to 250KB because is was easy to achieve, but I think we are suffering too much without a concrete reason. Some images are just larger, and here I want to show the details of the mesh.

@MakisH MakisH added this to the v202403.0 milestone Apr 3, 2024
@MakisH MakisH requested a review from davidscn April 3, 2024 22:01
@MakisH MakisH self-assigned this Apr 3, 2024
@MakisH MakisH requested a review from davidscn April 4, 2024 08:58
@MakisH MakisH mentioned this pull request Apr 4, 2024
53 tasks
Copy link
Member Author

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume from the comments that this has been implicitly approved.

@MakisH MakisH merged commit feecb7c into precice:develop Apr 4, 2024
1 check passed
@MakisH MakisH deleted the update-multi-flaps-image branch April 4, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants