Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding FEniCSx solver to partitioned-heat-equation tutorial #317

Merged
merged 7 commits into from
Jan 23, 2023

Conversation

PhilipHildebrand
Copy link
Contributor

This PR is to add a FEniCSx solver that is currently being developed at https://github.com/precice/fenicsx-adapter to the partitioned-heat-equation tutorial. We opted for a minimal working release, so parallel runs and vector-valued functions are not yet supported.

Copy link
Member

@BenjaminRodenberg BenjaminRodenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly minor cleanup work (commented out code and todos) and style. Please also make sure to update the README.md file of the tutorial case.

partitioned-heat-conduction/fenicsx/errorcomputation.py Outdated Show resolved Hide resolved
partitioned-heat-conduction/fenicsx/heat.py Outdated Show resolved Hide resolved
partitioned-heat-conduction/fenicsx/heat.py Outdated Show resolved Hide resolved
partitioned-heat-conduction/fenicsx/heat.py Outdated Show resolved Hide resolved
partitioned-heat-conduction/fenicsx/heat.py Outdated Show resolved Hide resolved
partitioned-heat-conduction/fenicsx/my_enums.py Outdated Show resolved Hide resolved
partitioned-heat-conduction/fenicsx/problem_setup.py Outdated Show resolved Hide resolved
partitioned-heat-conduction/fenicsx/problem_setup.py Outdated Show resolved Hide resolved
partitioned-heat-conduction/fenicsx/problem_setup.py Outdated Show resolved Hide resolved
partitioned-heat-conduction/fenicsx/problem_setup.py Outdated Show resolved Hide resolved
BenjaminRodenberg added a commit to PhilipHildebrand/fenicsx-adapter that referenced this pull request Dec 22, 2022
@BenjaminRodenberg
Copy link
Member

BenjaminRodenberg commented Dec 22, 2022

The CI pipeline runs into a problem: https://github.com/precice/fenicsx-adapter/actions/runs/3761247482/jobs/6392790304#step:8:46

Can you reproduce this locally? We can also try to fix this together in our meeting tomorrow.

@BenjaminRodenberg
Copy link
Member

The CI pipeline runs into a problem: https://github.com/precice/fenicsx-adapter/actions/runs/3761247482/jobs/6392790304#step:8:46

Can you reproduce this locally? We can also try to fix this together in our meeting tomorrow.

This was a problem introduced by some changes I introduced in PhilipHildebrand/fenicsx-adapter@038aa4f and reverted in precice/fenicsx-adapter@8c777c4. This should be fine.

Copy link
Member

@IshaanDesai IshaanDesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looka good 👍 we are almost there. Currently FEniCSx outputs xdmf and h5 files. Do you know how does one view them? Can we output VTK or VTU files? That would be the appropriate output file format if we look at other tutorials.

@PhilipHildebrand
Copy link
Contributor Author

Looka good +1 we are almost there. Currently FEniCSx outputs xdmf and h5 files. Do you know how does one view them? Can we output VTK or VTU files? That would be the appropriate output file format if we look at other tutorials.

The XDMF files can be opened with Paraview. From what I can tell, the h5 files are a byproduct of creating the XDMF files and are pretty much irrelevant. I've tried to create VTK files, but they don't show the temperature curve at t=0 for some reason and I don't know why.

@IshaanDesai
Copy link
Member

XDMF files can indeed be viewed in ParaView, provided the correct filer is selected. Lets keep this file format now, as it seems that FEniCSx also recommends it. @PhilipHildebrand can you resolve the conflict in the README so that we can merge this PR?

@IshaanDesai IshaanDesai merged commit d1a041a into precice:develop Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants