chore: Sort select inputs in Filter Config modal alphabetically #51
Conversation
agatapst
changed the title
Codecov Report
@@ Coverage Diff @@
## dashboard-native-filters #51 +/- ##
=========================================================
Coverage 64.15% 64.15%
=========================================================
Files 461 461
Lines 28386 28386
=========================================================
Hits 18211 18211
Misses 10175 10175
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
agatapst
changed the title
| @@ -65,7 +65,12 @@ export function ColumnSelect({ | |||
| endpoint: `/api/v1/dataset/${datasetId}`, | |||
| }).then( | |||
| ({ json: { result } }) => { | |||
| return result.columns.map((col: any) => col.column_name); | |||
| return result.columns | |||
| .map((col: any) => col.column_name) | |||
There was a problem hiding this comment.
For the backlog: add types to the frontend for relevant backend models.
| return result.columns | ||
| .map((col: any) => col.column_name) | ||
| .sort( | ||
| (a: ColumnSelectValue['label'], b: ColumnSelectValue['label']) => |
There was a problem hiding this comment.
Not super strong opinion, but this might be clearer if we just use the string type here.
There was a problem hiding this comment.
I was hesitating for these types here, so I like the idea for simplify them to "string", thanks.
agatapst
force-pushed
the
native-filters/sort-select-input
branch
from
f1420b0
to
d52a419
Compare
SUMMARY
The aim of this PR is to sort select inputs (datasource & field inputs located in Filter Config Modal) alphabetically.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before:
after:
TEST PLAN
Verify manually:
ADDITIONAL INFORMATION
cc @villebro @suddjian