Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Sort select inputs in Filter Config modal alphabetically #51

Merged
merged 2 commits into from
Dec 4, 2020
Merged

chore: Sort select inputs in Filter Config modal alphabetically #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40fe216
Sort select input alphabetically
agatapst Dec 3, 2020
d52a419
Change type for sorting elements
agatapst Dec 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion superset-frontend/src/components/SupersetResourceSelect.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,9 @@ export default function SupersetResourceSelect<T = unknown, V = string>({
endpoint: `/api/v1/${resource}/?q=${query}`,
}).then(
response => {
return response.json.result.map(transformItem);
return response.json.result
.map(transformItem)
.sort((a: Value<V>, b: Value<V>) => a.label.localeCompare(b.label));
},
async badResponse => {
const { error, message } = await getClientErrorObject(badResponse);
Expand Down
4 changes: 3 additions & 1 deletion superset-frontend/src/dashboard/components/nativeFilters/ColumnSelect.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,9 @@ export function ColumnSelect({
endpoint: `/api/v1/dataset/${datasetId}`,
}).then(
({ json: { result } }) => {
return result.columns.map((col: any) => col.column_name);
return result.columns
.map((col: any) => col.column_name)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the backlog: add types to the frontend for relevant backend models.

.sort((a: string, b: string) => a.localeCompare(b));
},
async badResponse => {
const { error, message } = await getClientErrorObject(badResponse);
Expand Down