Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) (MODULES-10385) - Allow vsys to be set #119

Closed
wants to merge 3 commits into from

Conversation

david22swan
Copy link
Member

@david22swan david22swan commented Mar 19, 2020

@david22swan david22swan requested a review from a team March 19, 2020 13:59
@david22swan david22swan added feature New feature or request wip labels Mar 19, 2020
@david22swan david22swan force-pushed the MODULES-10385 branch 3 times, most recently from 356dd98 to 58349ba Compare March 19, 2020 14:14
@codecov
Copy link

codecov bot commented Mar 19, 2020

Codecov Report

Merging #119 into master will decrease coverage by 4.35%.
The diff coverage is 30.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##            master     #119      +/-   ##
===========================================
- Coverage   100.00%   95.64%   -4.36%     
===========================================
  Files           40       41       +1     
  Lines         1136     1195      +59     
===========================================
+ Hits          1136     1143       +7     
- Misses           0       52      +52     
Impacted Files Coverage Δ
lib/puppet/type/panos_address.rb 100.00% <ø> (ø)
lib/puppet/type/panos_address_group.rb 100.00% <ø> (ø)
lib/puppet/type/panos_nat_policy.rb 100.00% <ø> (ø)
lib/puppet/type/panos_security_policy_rule.rb 100.00% <ø> (ø)
lib/puppet/type/panos_service.rb 100.00% <ø> (ø)
lib/puppet/type/panos_service_group.rb 100.00% <ø> (ø)
lib/puppet/type/panos_tag.rb 100.00% <ø> (ø)
lib/puppet/type/panos_zone.rb 100.00% <ø> (ø)
lib/puppet/provider/panos_vsys_base.rb 11.86% <11.86%> (ø)
lib/puppet/provider/panos_address/panos_address.rb 100.00% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49f1c85...c614554. Read the comment docs.

lib/puppet/provider/panos_vsys_base.rb Outdated Show resolved Hide resolved
lib/puppet/type/panos_address.rb Outdated Show resolved Hide resolved
lib/puppet/provider/panos_vsys_base.rb Outdated Show resolved Hide resolved
lib/puppet/provider/panos_vsys_base.rb Outdated Show resolved Hide resolved
lib/puppet/provider/panos_vsys_base.rb Show resolved Hide resolved
lib/puppet/provider/panos_vsys_base.rb Outdated Show resolved Hide resolved
lib/puppet/type/panos_address.rb Outdated Show resolved Hide resolved
- Can retrieve vsys of address
- Can set vsys for address
David Swan added 2 commits March 24, 2020 10:42
…nged

- Due to issues detailed within the ticket this is accomplished by deleting and recreating the address
- panos_address_group
- panos_net_policy
- panos_security_policy_rule
- panos_service_group
- panos_service
- panos_tag
- panos_zone
@david22swan david22swan changed the title (MODULES-10385) - Allow vsys to be set (WIP) (MODULES-10385) - Allow vsys to be set Mar 26, 2020
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


David Swan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants