Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) (MODULES-10385) - Allow vsys to be set #128

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

david22swan
Copy link
Member

@david22swan david22swan commented Apr 19, 2021

Note: In regards to naming conventions for the various types for which the vsys can be set, we are moving forward with the assumption that names must be unique across all separate vsys, not just within them as that is what is indicated within the following document: https://docs.paloaltonetworks.com/pan-os/7-1/pan-os-web-interface-help/objects/objects-addresses

PR has been recreated, see #119 PR linked below for additional information.

David Swan added 3 commits March 23, 2020 16:01
- Can retrieve vsys of address
- Can set vsys for address
…nged

- Due to issues detailed within the ticket this is accomplished by deleting and recreating the address
- panos_address_group
- panos_net_policy
- panos_security_policy_rule
- panos_service_group
- panos_service
- panos_tag
- panos_zone
@david22swan david22swan added feature New feature or request wip labels Apr 19, 2021
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


David Swan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@puppet-community-rangefinder
Copy link

panos_address is a type

that may have no external impact to Forge modules.

panos_address_group is a type

that may have no external impact to Forge modules.

panos_nat_policy is a type

that may have no external impact to Forge modules.

panos_security_policy_rule is a type

that may have no external impact to Forge modules.

panos_service is a type

that may have no external impact to Forge modules.

panos_service_group is a type

that may have no external impact to Forge modules.

panos_tag is a type

that may have no external impact to Forge modules.

panos_zone is a type

that may have no external impact to Forge modules.

This module is declared in 1 of 576 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@codecov
Copy link

codecov bot commented Apr 19, 2021

Codecov Report

Merging #128 (c614554) into main (49f1c85) will decrease coverage by 4.34%.
The diff coverage is 30.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##              main     #128      +/-   ##
===========================================
- Coverage   100.00%   95.65%   -4.35%     
===========================================
  Files           40       41       +1     
  Lines         1136     1196      +60     
===========================================
+ Hits          1136     1144       +8     
- Misses           0       52      +52     
Impacted Files Coverage Δ
lib/puppet/type/panos_address.rb 100.00% <ø> (ø)
lib/puppet/type/panos_address_group.rb 100.00% <ø> (ø)
lib/puppet/type/panos_nat_policy.rb 100.00% <ø> (ø)
lib/puppet/type/panos_security_policy_rule.rb 100.00% <ø> (ø)
lib/puppet/type/panos_service.rb 100.00% <ø> (ø)
lib/puppet/type/panos_service_group.rb 100.00% <ø> (ø)
lib/puppet/type/panos_tag.rb 100.00% <ø> (ø)
lib/puppet/type/panos_zone.rb 100.00% <ø> (ø)
lib/puppet/provider/panos_vsys_base.rb 11.86% <11.86%> (ø)
lib/puppet/provider/panos_address/panos_address.rb 100.00% <100.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49f1c85...c614554. Read the comment docs.

@david22swan david22swan marked this pull request as draft July 14, 2021 13:34
@chelnak
Copy link
Contributor

chelnak commented Feb 23, 2022

Not currently testable in its current form. We will come back to this soon.

@chelnak chelnak removed the wip label Mar 14, 2022
@github-actions
Copy link

This PR has been marked as stale because it has been open for a while and has had no recent activity. If this PR is still important to you please drop a comment below and we will add this to our backlog to complete. Otherwise, it will be closed in 7 days.

@github-actions
Copy link

Hello! 👋

This pull request has been open for a while and has had no recent activity. We've labelled it with attention-needed so that we can get a clear view of which PRs need our attention.

If you are waiting on a response from us we will try and address your comments on a future Community Day.

Alternatively, if it is no longer relevant to you please close the PR with a comment.

Please note that if a pull request receives no update for 7 after it has been labelled, it will be closed. We are always happy to re-open pull request if they have been closed in error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants