-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(WIP) (MODULES-10385) - Allow vsys to be set #128
base: main
Are you sure you want to change the base?
Conversation
- Can retrieve vsys of address - Can set vsys for address
…nged - Due to issues detailed within the ticket this is accomplished by deleting and recreating the address
- panos_address_group - panos_net_policy - panos_security_policy_rule - panos_service_group - panos_service - panos_tag - panos_zone
David Swan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
panos_address is a typethat may have no external impact to Forge modules. panos_address_group is a typethat may have no external impact to Forge modules. panos_nat_policy is a typethat may have no external impact to Forge modules. panos_security_policy_rule is a typethat may have no external impact to Forge modules. panos_service is a typethat may have no external impact to Forge modules. panos_service_group is a typethat may have no external impact to Forge modules. panos_tag is a typethat may have no external impact to Forge modules. panos_zone is a typethat may have no external impact to Forge modules. This module is declared in 1 of 576 indexed public
|
Codecov Report
@@ Coverage Diff @@
## main #128 +/- ##
===========================================
- Coverage 100.00% 95.65% -4.35%
===========================================
Files 40 41 +1
Lines 1136 1196 +60
===========================================
+ Hits 1136 1144 +8
- Misses 0 52 +52
Continue to review full report at Codecov.
|
Not currently testable in its current form. We will come back to this soon. |
This PR has been marked as stale because it has been open for a while and has had no recent activity. If this PR is still important to you please drop a comment below and we will add this to our backlog to complete. Otherwise, it will be closed in 7 days. |
Hello! 👋 This pull request has been open for a while and has had no recent activity. We've labelled it with If you are waiting on a response from us we will try and address your comments on a future Community Day. Alternatively, if it is no longer relevant to you please close the PR with a comment. Please note that if a pull request receives no update for 7 after it has been labelled, it will be closed. We are always happy to re-open pull request if they have been closed in error. |
Note: In regards to naming conventions for the various types for which the vsys can be set, we are moving forward with the assumption that names must be unique across all separate vsys, not just within them as that is what is indicated within the following document: https://docs.paloaltonetworks.com/pan-os/7-1/pan-os-web-interface-help/objects/objects-addresses
PR has been recreated, see #119 PR linked below for additional information.