Skip to content

Commit

Permalink
#546 remove model
Browse files Browse the repository at this point in the history
  • Loading branch information
valentinsulzer committed Dec 12, 2019
1 parent 0606b24 commit a68470e
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 33 deletions.
1 change: 0 additions & 1 deletion pybamm/models/full_battery_models/lead_acid/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
from .higher_order import (
BaseHigherOrderModel,
FOQS,
FOQSAverageCorrection,
Composite,
CompositeAverageCorrection,
CompositeExtended,
Expand Down
32 changes: 0 additions & 32 deletions pybamm/models/full_battery_models/lead_acid/higher_order.py
Original file line number Diff line number Diff line change
Expand Up @@ -213,38 +213,6 @@ def set_full_porosity_submodel(self):
pass


class FOQSAverageCorrection(FOQS):
"""First-order quasi-static model for lead-acid, from [1]_.
Uses leading-order model from :class:`pybamm.lead_acid.LOQS`
References
----------
.. [1] V Sulzer, SJ Chapman, CP Please, DA Howey, and CW Monroe. Faster Lead-Acid
Battery Simulations from Porous-Electrode Theory: II. Asymptotic Analysis.
arXiv preprint arXiv:1902.01774, 2019.
**Extends:** :class:`pybamm.lead_acid.BaseHigherOrderModel`
"""

def __init__(self, options=None, name="FOQS model"):
super().__init__(options, name)

def set_electrolyte_diffusion_submodel(self):
self.submodels[
"electrolyte diffusion"
] = pybamm.electrolyte.stefan_maxwell.diffusion.FirstOrderAverageCorrection(
self.param, self.reactions
)

@property
def default_solver(self):
"""
Create and return the default solver for this model
"""
return pybamm.ScikitsDaeSolver()


class Composite(BaseHigherOrderModel):
"""Composite model for lead-acid, from [1]_.
Uses leading-order model from :class:`pybamm.lead_acid.LOQS`
Expand Down

0 comments on commit a68470e

Please sign in to comment.