Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2+1D lead-acid #546

Closed
valentinsulzer opened this issue Jul 21, 2019 · 0 comments · Fixed by #564 or #635
Closed

2+1D lead-acid #546

valentinsulzer opened this issue Jul 21, 2019 · 0 comments · Fixed by #564 or #635
Assignees
@valentinsulzer
Labels
feature

Comments

@valentinsulzer
Copy link
Member

Start to create 1+1D and 2+1D lead-acid models
@valentinsulzer valentinsulzer self-assigned this Jul 21, 2019
valentinsulzer added a commit that referenced this issue Jul 21, 2019
@valentinsulzer
#546 reformat options
b2707ba
valentinsulzer added a commit that referenced this issue Jul 21, 2019
@valentinsulzer
#546 setting up structure
aad5945
@valentinsulzer valentinsulzer mentioned this issue Jul 22, 2019
Closed
valentinsulzer added a commit that referenced this issue Jul 23, 2019
@valentinsulzer
#546 merge 545
3951865
valentinsulzer added a commit that referenced this issue Jul 23, 2019
@valentinsulzer
#546 add 0D submesh
81ad4dc
valentinsulzer added a commit that referenced this issue Jul 23, 2019
@valentinsulzer
#546 loqs working with zero-dimensional current collector
2c52b8d
valentinsulzer added a commit that referenced this issue Jul 23, 2019
@valentinsulzer
#546 fix a bunch of unit tests
0689ee2
valentinsulzer added a commit that referenced this issue Jul 23, 2019
@valentinsulzer
#546 messing around with shapes. added SecondaryBroadcast operator
4aa9926
valentinsulzer added a commit that referenced this issue Jul 23, 2019
@valentinsulzer
#546 fix spme and spme unit tests
a8efd42
valentinsulzer added a commit that referenced this issue Jul 23, 2019
@valentinsulzer
#546 fix loqs and composite unit tests
065d06e
valentinsulzer added a commit that referenced this issue Jul 23, 2019
@valentinsulzer
#546 fix foqs
a24af72
valentinsulzer added a commit that referenced this issue Jul 23, 2019
@valentinsulzer
#546 start Newman-Tiedemann
69b1805
valentinsulzer added a commit that referenced this issue Jul 23, 2019
@valentinsulzer
#546 some progress with Newman-Tiedemann
c762627
valentinsulzer added a commit that referenced this issue Jul 23, 2019
@valentinsulzer
#546 merge updates from master
86dc0f2
valentinsulzer added a commit that referenced this issue Jul 23, 2019
@valentinsulzer
#546 fix lead-acid models
0a79b9b
valentinsulzer added a commit that referenced this issue Jul 23, 2019
@valentinsulzer
#546 use secondary dimension instead of secondary broadcast
f277217
valentinsulzer added a commit that referenced this issue Jul 23, 2019
@valentinsulzer
#546 explicitly use FullBroadcast
13a305b
valentinsulzer added a commit that referenced this issue Jul 23, 2019
@valentinsulzer
#546 make FullBroadcast explicit
8b02110
valentinsulzer added a commit that referenced this issue Jul 23, 2019
@valentinsulzer
#546 fix unit tests except repr
6fe2a26
valentinsulzer added a commit that referenced this issue Jul 23, 2019
@valentinsulzer
#546 some progress, sorting out thermal
131939e
@valentinsulzer valentinsulzer mentioned this issue Jul 23, 2019
Closed
valentinsulzer added a commit that referenced this issue Jul 23, 2019
@valentinsulzer
#546 fix temperature
b85f455
valentinsulzer added a commit that referenced this issue Jul 23, 2019
@valentinsulzer
#546 do fix for #547
ba4dee3
valentinsulzer added a commit that referenced this issue Jul 23, 2019
@valentinsulzer
#546 loqs 1+1D runs, but some bugs
7ca0f15
valentinsulzer added a commit that referenced this issue Jul 24, 2019
@valentinsulzer
#546 change to auxiliary domains and remove SecondaryBroadcast
80e63b6
valentinsulzer added a commit that referenced this issue Jul 24, 2019
@valentinsulzer
#546 clean up secondary broadcast stuff
dd78841
valentinsulzer added a commit that referenced this issue Jul 24, 2019
@valentinsulzer
#546 reformat models with auxiliary domains
be2e1af
valentinsulzer added a commit that referenced this issue Jul 24, 2019
@valentinsulzer
#546 fix unit tests except QuickPlot
a8084f7
valentinsulzer added a commit that referenced this issue Sep 13, 2019
@valentinsulzer
#546 merge master
ca19833
valentinsulzer added a commit that referenced this issue Sep 24, 2019
@valentinsulzer
#546 A_e algebraic
8a28352
valentinsulzer added a commit that referenced this issue Sep 24, 2019
@valentinsulzer
#546 merge master
3f5db34
valentinsulzer added a commit that referenced this issue Sep 25, 2019
@valentinsulzer
#546 more merges
73b1d76
valentinsulzer added a commit that referenced this issue Sep 25, 2019
@valentinsulzer
#546 make discretised delta function dense
c1ec330
valentinsulzer added a commit that referenced this issue Sep 26, 2019
@valentinsulzer
#546 fix delta function
107e627
valentinsulzer added a commit that referenced this issue Sep 26, 2019
@valentinsulzer
#546 redo charge results with delta function
b6188ce
@valentinsulzer valentinsulzer mentioned this issue Sep 26, 2019
Merged
7 tasks
valentinsulzer added a commit that referenced this issue Sep 26, 2019
@valentinsulzer
#546 merge master
01d3f94
valentinsulzer added a commit that referenced this issue Dec 11, 2019
@valentinsulzer
#546 merge master
392aa24
valentinsulzer added a commit that referenced this issue Dec 11, 2019
@valentinsulzer
#546 fix import
171de92
valentinsulzer added a commit that referenced this issue Dec 11, 2019
@valentinsulzer
#546 fix doc
0606b24
valentinsulzer added a commit that referenced this issue Dec 12, 2019
@valentinsulzer
#546 remove model
a68470e
valentinsulzer added a commit that referenced this issue Dec 12, 2019
@valentinsulzer
#546 fix a few tests
6335ad3
valentinsulzer added a commit that referenced this issue Dec 12, 2019
@valentinsulzer
#546 still fixing tests
c1d9c62
valentinsulzer added a commit that referenced this issue Dec 13, 2019
@valentinsulzer
#546 merge master
755857e
valentinsulzer added a commit that referenced this issue Feb 5, 2020
@valentinsulzer
#546 merge master
3855d0e
valentinsulzer added a commit that referenced this issue Mar 29, 2020
@valentinsulzer
#546 merge develop
d71cd6b
valentinsulzer added a commit that referenced this issue Mar 29, 2020
@valentinsulzer
#546 merge #923
6500ac9
valentinsulzer added a commit that referenced this issue Mar 29, 2020
@valentinsulzer
#546 fix tests locally
20b9815
valentinsulzer added a commit that referenced this issue Mar 29, 2020
@valentinsulzer
#546 fix integration tests
50c4f8c
valentinsulzer added a commit that referenced this issue Apr 5, 2020
@valentinsulzer
#546 merge develop
6f454f2
valentinsulzer added a commit that referenced this issue Apr 6, 2020
@valentinsulzer
#546 remove macinnes_tplus
ce41f00
valentinsulzer added a commit that referenced this issue Apr 6, 2020
@valentinsulzer
#546 remove levenshtein
85bc1fa
valentinsulzer added a commit that referenced this issue Apr 6, 2020
@valentinsulzer
#546 changelog
3bf83df
valentinsulzer added a commit that referenced this issue Apr 8, 2020
@valentinsulzer
#546 rob comments
1302684
valentinsulzer added a commit that referenced this issue Apr 9, 2020
@valentinsulzer
#546 fix tests, clean up convection
1fcbd4e
valentinsulzer added a commit that referenced this issue Apr 9, 2020
@valentinsulzer
#546 merge develop
91a3a7b
valentinsulzer added a commit that referenced this issue Apr 9, 2020
@valentinsulzer
#546 remove thermal cc
db1ba9d
valentinsulzer added a commit that referenced this issue Apr 9, 2020
@valentinsulzer
#933 merge #546
23c6e2a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valentinsulzer valentinsulzer

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 546 models pybamm-team/PyBaMM
Issue 546 convection pybamm-team/PyBaMM
1 participant
@valentinsulzer