Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up electrolyte submodels #923

Closed
valentinsulzer opened this issue Mar 27, 2020 · 0 comments · Fixed by #927
Closed

Clean up electrolyte submodels #923

valentinsulzer opened this issue Mar 27, 2020 · 0 comments · Fixed by #927
Assignees
@valentinsulzer

Comments

@valentinsulzer
Copy link
Member

I think it would be clearer if these were two separate submodels: "electrolyte_diffusion" and "electrolyte_conductivity". We also don't need to call it "stefan_maxwell" IMO as this is a bit misleading.

@TomTranter and @ferranbrosa this might raise conflicts with some changes you have made/are making so let me know if this is a problem
valentinsulzer added a commit that referenced this issue Mar 28, 2020
@valentinsulzer
#923 reformat electrolyte submodels
8ba60aa
valentinsulzer added a commit that referenced this issue Mar 28, 2020
@valentinsulzer
#923 some under-the-hood optimizations
f591eec
valentinsulzer added a commit that referenced this issue Mar 28, 2020
@valentinsulzer
#923 make casadi default solver for lead-acid
85e1ec6
valentinsulzer added a commit that referenced this issue Mar 28, 2020
@valentinsulzer
#923 changelog
6cabf93
@valentinsulzer valentinsulzer mentioned this issue Mar 28, 2020
Merged
8 tasks
valentinsulzer added a commit that referenced this issue Mar 28, 2020
@valentinsulzer
#923 docs
40e07e4
valentinsulzer added a commit that referenced this issue Mar 28, 2020
@valentinsulzer
#923 fix interface tests
aae9402
valentinsulzer added a commit that referenced this issue Mar 29, 2020
@valentinsulzer
#546 merge #923
6500ac9
valentinsulzer added a commit that referenced this issue Apr 2, 2020
@valentinsulzer
#923 merge develop
bed4ae3
valentinsulzer added a commit that referenced this issue Apr 2, 2020
@valentinsulzer
#923 merge develop
942b713
valentinsulzer added a commit that referenced this issue Apr 2, 2020
@valentinsulzer
#923 generalize broadcasts
a06580f
valentinsulzer added a commit that referenced this issue Apr 2, 2020
@valentinsulzer
#923 Rob and Scott comments
3c1c6cf
@valentinsulzer valentinsulzer self-assigned this Apr 4, 2020
valentinsulzer added a commit that referenced this issue Apr 5, 2020
@valentinsulzer
#923 fix composite extended model
796f8d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valentinsulzer valentinsulzer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 923 reformat electrolyte pybamm-team/PyBaMM
1 participant
@valentinsulzer